cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From purplecabbage <>
Subject [GitHub] cordova-plugin-vibration pull request: CB-8930: Vibration on Windo...
Date Wed, 29 Apr 2015 22:11:32 GMT
Github user purplecabbage commented on a diff in the pull request:
    --- Diff: src/windows/VibrationProxy.js ---
    @@ -35,26 +35,74 @@ function tryDoAction(actionName, success, fail, args, action) {
    -        success();        
    +        success && success();        
    --- End diff --
    Proxy calls are always called with a valid success + fail callback function.  No need
for the extra checks.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message