cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dblotsky <...@git.apache.org>
Subject [GitHub] cordova-medic pull request: [CB-8870] Consolidating medic code.
Date Wed, 29 Apr 2015 20:03:54 GMT
Github user dblotsky commented on a diff in the pull request:

    https://github.com/apache/cordova-medic/pull/47#discussion_r29374675
  
    --- Diff: bin/medic.js ---
    @@ -19,18 +19,44 @@
      * under the License.
      */
     
    -"use strict";
    +/* jshint node: true */
    +
    +// "use strict";
     
     // node dependencies
    -var fs = require("fs");
    -var os = require("os");
    +var fs   = require("fs");
    +var os   = require("os");
    +var path = require("path");
     
     // external dependencies
     var shelljs  = require("shelljs");
     var optimist = require("optimist");
     
    +// internal dependencies
    +var testwait  = require("./lib/testwait");
    +var testcheck = require("./lib/testcheck");
    +
     // constants
    -var MAX_REMOVAL_ATTEMPTS = 3;
    +var MAX_REMOVAL_ATTEMPTS    = 3;
    +var CORDOVA_MEDIC_DIR       = "cordova-medic";
    +var DEFAULT_APP_PATH        = "mobilespec";
    +var DEFAULT_APP_ENTRY       = "index.html";
    +var ANDROID_TIMEOUT         = 120000;
    +var MEDIC_BUILD_PREFIX      = "medic-cli-build";
    +var DEFAULT_ENCODING        = "utf-8";
    +var DEFAULT_WINDOWS_VERSION = "store";
    +var WINDOWS_VERSION_CHOICES = ["store", "store80", "phone"];
    +var ONE_MINUTE              = 1 * 60;
    --- End diff --
    
    Good catch. Will add comments regarding units and fix the redundant multiplication.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message