cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robpaveza <...@git.apache.org>
Subject [GitHub] cordova-medic pull request: [CB-8870] Consolidating medic code.
Date Wed, 29 Apr 2015 19:16:55 GMT
Github user robpaveza commented on a diff in the pull request:

    https://github.com/apache/cordova-medic/pull/47#discussion_r29370291
  
    --- Diff: bin/medic.js ---
    @@ -39,9 +65,109 @@ var argv = optimist
         .argv;
     
     // helpers
    +function killTasks(taskNames) {
    +
    +    if (!taskNames || taskNames.length < 1) {
    +        console.warn("no tasks to kill");
    --- End diff --
    
    No tasks seems to equal success case.  If truly a usage error, throw, but otherwise this
seems unnecessarily chatty.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message