cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dblotsky <>
Subject [GitHub] cordova-mobile-spec pull request: CB-8927 Add media to cspMeta and...
Date Tue, 28 Apr 2015 23:58:13 GMT
Github user dblotsky commented on a diff in the pull request:
    --- Diff: www/csp-incl.js ---
    @@ -49,7 +49,13 @@ if (!window._disableCSP) {
         switch (PLAT) {
             case 'android':
             case 'ios':
    -            cspMetaContent = 'default-src \'self\';
connect-src \'self\';frame-src \'self\' data: gap:;
img-src \'self\' data:; style-src \'self\' \'unsafe-inline\'';
    +        case 'windows8':
    +            cspMetaContent = 'default-src \'self\';'
    +                            ' connect-src \'self\';'
    +                            ' media-src \'self\';'
    +                            ' frame-src \'self\' data: gap:;' +
    +                            ' img-src \'self\' data:;' +
    +                            ' style-src \'self\' \'unsafe-inline\'';
    --- End diff --
    Even though the fact that this fixes things on Windows is actually really valuable, the
formatting is the best thing about this change. Small nit: might be better to use double-quotes
for the strings so you won't have to escape as much.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message