cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robpaveza <...@git.apache.org>
Subject [GitHub] cordova-windows pull request: Added support for Windows 10
Date Tue, 28 Apr 2015 17:13:14 GMT
Github user robpaveza commented on a diff in the pull request:

    https://github.com/apache/cordova-windows/pull/70#discussion_r29265000
  
    --- Diff: template/cordova/lib/run.js ---
    @@ -92,21 +152,26 @@ module.exports.help = function () {
         console.log('    run --target=7988B8C3-3ADE-488d-BA3E-D052AC9DC710');
         console.log('    run --device --release');
         console.log('    run --emulator --debug');
    +    console.log('    run --device --appx=phone-8.1');
         console.log('');
    +
         process.exit(0);
     };
     
     
     function getWindowsTargetVersion() {
         var config = new ConfigParser(path.join(ROOT, 'config.xml'));
    -    var windowsTargetVersion = config.getPreference('windows-target-version');
    +    var windowsTargetVersion = config.getWindowsTargetVersion();
         switch(windowsTargetVersion) {
    -    case '8':
    -    case '8.0':
    -        return '8.0';
    -    case '8.1':
    -        return '8.1';
    -    default:
    -        throw new Error('Unsupported windows-target-version value: ' + windowsTargetVersion);
    +        case '8':
    +        case '8.0':
    +            return '8.0';
    +        case '8.1':
    +            return '8.1';
    +        case '10.0':
    --- End diff --
    
    Probably a fair comment.  I expect us to see more minor revisions over time (similar to
how 8 and 8.1 were, although with the same project instead of different ones) and we designed
it with that in mind.  If you want to target 10 base, you can use "UAP" here instead (aligned
with the --appx=uap CLI option).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message