cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sgrebnov <...@git.apache.org>
Subject [GitHub] cordova-windows pull request: Added support for Windows 10
Date Tue, 28 Apr 2015 14:41:18 GMT
Github user sgrebnov commented on a diff in the pull request:

    https://github.com/apache/cordova-windows/pull/70#discussion_r29249044
  
    --- Diff: spec/unit/build.spec.js ---
    @@ -44,11 +44,17 @@ function createConfigParserMock(winVersion, phoneVersion) {
             return {
                 getPreference: function(prefName) {
                     switch (prefName) {
    -                    case 'windows-target-version':
    +                    case 'WindowsTargetVersion':
                             return winVersion;
    -                    case 'windows-phone-target-version':
    --- End diff --
    
    `windows-phone-target-version` should continue to work. See `config.getWindowsPhoneTargetVersion`
implementation
    ```
     getWindowsPhoneTargetVersion: function() {
    ...
    +        var explicitPreference = this.getPreference('WindowsPhoneTargetVersion') || this.getPreference('windows-phone-target-version');
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message