cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dpolivy <...@git.apache.org>
Subject [GitHub] cordova-plugin-file-transfer pull request: CB-8761 [wp8]: Copy coo...
Date Fri, 24 Apr 2015 21:38:45 GMT
Github user dpolivy commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-file-transfer/pull/74#discussion_r29088108
  
    --- Diff: src/wp/FileTransfer.cs ---
    @@ -210,6 +216,80 @@ public FileTransferProgress(long bTotal = 0, long bLoaded = 0)
             }
     
             /// <summary>
    +        /// Helper method to copy all relevant cookies from the WebBrowser control into
a header on
    +        /// the HttpWebRequest
    +        /// </summary>
    +        /// <param name="browser">The source browser to copy the cookies from</param>
    +        /// <param name="webRequest">The destination HttpWebRequest to add the
cookie header to</param>
    +        /// <returns>Nothing</returns>
    +        private async Task CopyCookiesFromWebBrowser(HttpWebRequest webRequest)
    +        {
    +            var tcs = new TaskCompletionSource<object>();
    +
    +            // Accessing WebBrowser needs to happen on the UI thread
    +            Deployment.Current.Dispatcher.BeginInvoke(() =>
    --- End diff --
    
    @sgrebnov I think the Dispatcher only has the async methods on WP, unfortunately. If you
have another suggestion, though, I'm happy to look at it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message