cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From agrieve <...@git.apache.org>
Subject [GitHub] cordova-android pull request: CB-8902: use immersive mode when ava...
Date Fri, 24 Apr 2015 13:13:13 GMT
Github user agrieve commented on a diff in the pull request:

    https://github.com/apache/cordova-android/pull/175#discussion_r29046696
  
    --- Diff: framework/src/org/apache/cordova/CordovaActivity.java ---
    @@ -130,6 +147,18 @@ public void onCreate(Bundle savedInstanceState) {
                 cordovaInterface.restoreInstanceState(savedInstanceState);
             }
         }
    +
    +    private void setSystemUiVisibilityMode(Window window) {
    --- End diff --
    
    If you're going to pass in the window, then you should make this method static.
    If you're going to call it "set...Mode", then it should accept the mode as a parameter.
    Really though, hoping you don't need the listener so that you don't need a helper at all.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message