cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From agrieve <...@git.apache.org>
Subject [GitHub] cordova-plugin-camera pull request: solves CB-8804 https://github....
Date Wed, 22 Apr 2015 15:14:55 GMT
Github user agrieve commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-camera/pull/83#discussion_r28882307
  
    --- Diff: src/android/CameraLauncher.java ---
    @@ -632,73 +645,79 @@ else if (destType == FILE_URI || destType == NATIVE_URI) {
          */
         public void onActivityResult(int requestCode, int resultCode, Intent intent) {
     
    -        // Get src and dest types from request code for a Camera Activity
    -        int srcType = (requestCode / 16) - 1;
    -        int destType = (requestCode % 16) - 1;
    -
    -        // If Camera Crop
    -        if (requestCode >= CROP_CAMERA) {
    -            if (resultCode == Activity.RESULT_OK) {
    +        if (this.imageUri == null && this.getPictureFromGallery == false) {
    --- End diff --
    
    Would it be more appropriate to check if `callbackContext == null`? An app can be evicted
even when getting a picture from the gallery.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message