cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nikhilkh <>
Subject [GitHub] cordova-plugin-camera pull request: CB-8404 Rotate camera feed wit...
Date Mon, 20 Apr 2015 17:13:37 GMT
Github user nikhilkh commented on a diff in the pull request:
    --- Diff: src/windows/CameraProxy.js ---
    @@ -310,29 +319,50 @@ function takePictureFromCameraWP(successCallback, errorCallback,
args) {
             tempFolder.createFileAsync(fileName, generateUniqueCollisionOption)
                 .then(function(tempCapturedFile) {
    -                capturedFile = tempCapturedFile;
    -                return capture.capturePhotoToStorageFileAsync(encodingProperties, capturedFile);
    +                return new WinJS.Promise(function (complete) {
    +                    var imgStream = new Windows.Storage.Streams.InMemoryRandomAccessStream();
    --- End diff --
    imgStream.close() needs to be invoked once you are done using it to release system resources.
It needs to be part of the success and error case.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message