cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shazron <...@git.apache.org>
Subject [GitHub] cordova-plugin-dialogs pull request: Fix CB-7734. Changed plugin t...
Date Sat, 18 Apr 2015 16:03:29 GMT
Github user shazron commented on the pull request:

    https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-94176996
  
    Actually the test project was just to repro the failing case. I haven't
    evaluated your full landscape fix yet.
    
    On Saturday, April 18, 2015, Julio César <notifications@github.com> wrote:
    
    > If been looking into your test project and the last commented line should
    > be alertController.view.frame = alertFrame; not alertController.view.frame
    > = [UIScreen mainScreen].applicationFrame; so it works on landscape on
    > iPhone/iPod, my latest commit already have that line changed
    >
    > —
    > Reply to this email directly or view it on GitHub
    > <https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-94154670>
    > .
    >



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message