cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dblotsky <>
Subject [GitHub] cordova-medic pull request: [CB-8805] Added ability to specify a c...
Date Wed, 08 Apr 2015 18:44:12 GMT
Github user dblotsky commented on a diff in the pull request:
    --- Diff: buildbot-conf/cordova.conf ---
    @@ -234,8 +245,15 @@ plugins_cleanup_steps = [
     common_plugins_steps = plugins_cleanup_steps + get_medic_steps + [
         # download medic's config to slave
    -    Download(mastersrc=PROJECTS_CONFIG_FILE, slavedest='cordova-medic/cordova-repos.json'),
    -    Download(mastersrc=MEDIC_CONFIG_FILE, slavedest='cordova-medic/config.json'),
    +    Download(mastersrc=MEDIC_CONFIG_FILE, slavedest='cordova-medic/config.json', description='downloading
master\'s config'),
    +    # download repo config
    +    # NOTE:
    +    #      only one of these steps should be executed; thanks
    +    #      to Buildbot there is no good if-else construct for
    +    #      builds, so we have two steps with 'doStepIf's
    +    SH(command=['curl', P(REPOS_PROPERTY_NAME), '--output', 'cordova-medic/cordova-repos.json'],
description='downloading custom repo config', doStepIf=dont_use_default_repos),
    +    Download(mastersrc=PROJECTS_CONFIG_FILE, slavedest='cordova-medic/cordova-repos.json',
description='downloading default repo config', doStepIf=use_default_repos),
    --- End diff --
    I wish it worked that way, but sadly [it does not](
:disappointed: The way to do what you're talking about is to implement a [custom step that
runs shell commands](,
which is just as convoluted.
    The way to solve it properly is to have only one download step and use a *default* property
value, like so: 
        `P('repositories_config', default=PROJECTS_CONFIG_FILE)`
    The issue right now is that the default file uses `FileDownload`, while the custom file
uses `ShellCommand(command=['curl', ...])`, and making both use the same one is also a convoluted
process. This will be fixed entirely once we switch to using [Buildbot Codebases](
for managing multiple repositories.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message