cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From akreienbring <...@git.apache.org>
Subject [GitHub] cordova-plugin-inappbrowser pull request: Added editablelocation o...
Date Sun, 05 Apr 2015 11:08:39 GMT
Github user akreienbring commented on the pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/73#issuecomment-89753645
  
    I just found a problem with the code of this pull request:
    Once you opend an Inappbrowser with the option 'editablelocaction=yes' all subsequent
instances of Inappbrowser will also show an editable location bar.
    
    I solved this locally by:
    Removing this method:
    ```
        /**
         * Should we make the location bar editable?
         * @return boolean
         */
        private boolean getEditableLocationBar() {
            return this.editableLocationBar;
        }
    ```
    and adding this:
    ```
        /**
         * Display a new browser with the specified URL.
         *
         * @param url           The url to load.
         * @param jsonObject
         */
        public String showWebPage(final String url, HashMap<String, Boolean> features)
{
            // Determine if we should hide the location bar.
            showLocationBar = true;
            openWindowHidden = false;
            editableLocationBar = false;
        ....
    ```
    
    And then I simply youse the option when creating the editText like this:
    ````
                    if(!editableLocationBar) {
                        edittext.setInputType(InputType.TYPE_NULL); // Will not except input...
Makes the text NON-EDITABLE
                    }
    ````



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message