cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shazron <...@git.apache.org>
Subject [GitHub] cordova-plugin-splashscreen pull request: CB-7204 Fixed race condi...
Date Fri, 03 Apr 2015 23:41:14 GMT
Github user shazron commented on the pull request:

    https://github.com/apache/cordova-plugin-splashscreen/pull/21#issuecomment-89458111
  
    This could be it:
    1. https://github.com/apache/cordova-plugin-splashscreen/blob/d2e62a551c950041cb4c9683624a04d931f4bee3/src/ios/CDVSplashScreen.m#L295-L296
    2. https://github.com/apache/cordova-plugin-splashscreen/blob/d2e62a551c950041cb4c9683624a04d931f4bee3/src/ios/CDVSplashScreen.m#L300
    
    All three instances in the blocks create strong references to self, which should be weak.
    Here is my attempt at a patch: https://gist.github.com/shazron/e45705f76bef4448139a
    
    Try it out.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message