cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vladimir-kotikov <...@git.apache.org>
Subject [GitHub] cordova-lib pull request:
Date Thu, 02 Apr 2015 08:35:54 GMT
Github user vladimir-kotikov commented on the pull request:

    https://github.com/apache/cordova-lib/commit/c7f441b302aa13f8f42d7b8b6979d3efeb030ec3#commitcomment-10540924
  
    In cordova-lib/src/cordova/lazy_load.js:
    In cordova-lib/src/cordova/lazy_load.js on line 120:
    This won't work as expected when short version is specified. For example, when istalling
`android@3.7` platform. spec property will be a range, like `>=3.7.0 <3.8.0` and `git_dload_dir`
will be invalid path.
    
    Probably we need to change a logic as following: 
    ```pseudocode
    search for already downloaded platform versions at path.join(util.libDirectory, platdir,
'cordova')
    if any exists, for each
        version = subfolder_name
        if semver.satisfies(subfolder_name, plat_spec.spec) then resolve with subfolder_full_path
    ...
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message