cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From agrieve <...@git.apache.org>
Subject [GitHub] cordova-android pull request: CB-8484: Adds support creating signe...
Date Wed, 01 Apr 2015 17:39:31 GMT
Github user agrieve commented on a diff in the pull request:

    https://github.com/apache/cordova-android/pull/164#discussion_r27591881
  
    --- Diff: bin/templates/cordova/lib/build.js ---
    @@ -422,11 +500,18 @@ function parseOpts(options, resolvedTarget) {
     module.exports.runClean = function(options) {
         var opts = parseOpts(options);
         var builder = builders[opts.buildMethod];
    -    return builder.prepEnv()
    +    return builder.prepEnv(opts)
         .then(function() {
    -        return builder.clean(opts.extraArgs);
    +        return builder.clean(opts);
         }).then(function() {
             shell.rm('-rf', path.join(ROOT, 'out'));
    +
    +        ['debug', 'release'].forEach(function(config) {
    +            var propertiesFilePath = path.join(ROOT, config + SIGNING_PROPERTIES);
    +            if(isAutoGenerated(propertiesFilePath)){
    +                shell.rm('-f', propertiesFilePath);
    --- End diff --
    
    I don't think clean is really used (the command isn't even wired up to CLI afaik, although
it really should be). If passwords are the concern, then probably we should be deleting the
files after building.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message