Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
Received-SPF: pass (athena.apache.org: domain of csantana23@gmail.com
 designates 209.85.214.182 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <68323E8E-A649-479D-933E-E9254953BF30@gmail.com>
References: 
 <BL2PR03MB417E0F43C29BC869905BC519E0A0@BL2PR03MB417.namprd03.prod.outlook.com>
	<CAK_TSXKgY84y+1UoGf8mPYQ6D9ZmAoveRa9q+TA-GJYXegr9yQ@mail.gmail.com>
	<68323E8E-A649-479D-933E-E9254953BF30@gmail.com>
Date: Thu, 26 Mar 2015 12:47:12 -0400
Message-ID: 
 <CAHYtTq=ga+423wY_ffG=LqyE6eMvix8+KCUMiV7SkfZz_=h7fg@mail.gmail.com>
Subject: Re: Cordova WP8: switching to Newtonsoft.Json
From: Carlos Santana <csantana23@gmail.com>
To: "dev@cordova.apache.org" <dev@cordova.apache.org>
Content-Type: multipart/alternative; boundary=e89a8ff1cf467f53d6051233c4ff

--e89a8ff1cf467f53d6051233c4ff
Content-Type: text/plain; charset=UTF-8

Jesse dumb question, what else is new 8-]

Can we do that Mark pointed out to add a reference to a location where the
windows project can get the dependency?
Like adding a nuget dependency entry, and then when app get's compile,
visual studio takes care of downloading Newtonsoft.Json from nuget
repository?


On Tue, Mar 24, 2015 at 1:38 PM, Jesse <purplecabbage@gmail.com> wrote:

> I am looking into this. We need to include source code, as we cannot
> distribute a dll.
> The pull-req is definitely dead except for the fact it contain part of
> this conversation.
>
>
>
>
> > On Mar 24, 2015, at 6:37 AM, Ian Clelland <iclelland@chromium.org>
> wrote:
> >
> > I'm not sure about whether Cordova has any specific policies -- there's
> no
> > hard rule that says we can't use third-party code, and even include it in
> > our distributions (see Cordova-Android and okhttp, for instance), but we
> > should probably discuss it on-list first.
> >
> > There are definitely rules, policies, and guidelines at the Apache level
> --
> > no distribution of binaries, for instance, and there are probably
> questions
> > of license interaction as well between Apache and MIT licenses, if we're
> > combining the code at all.
> >
> >
> >
> > On Tue, Mar 24, 2015 at 5:04 AM, Sergey Grebnov (Akvelon) <
> > v-segreb@microsoft.com> wrote:
> >
> >> This[1] PR is being opened for a while so let's make a final decision if
> >> we switch to Newtonsoft.Json  or reject it.
> >>
> >> The idea of adding Newtonsoft.Json (MIT license) [1] looks good to me
> and
> >> I can quickly add necessary improvements to make sure everything looks
> good
> >> and works - as per mobile spec tests there are no new issues found.
> >>
> >> But I'm not sure about our policies regarding adding new third party
> >> dependencies. Should it be discussed/voted here before merge? Does it
> >> documented somewhere?
> >>
> >> PS. If we go w/ Newtonsoft.Json   I propose to just add reference to
> >> compiled dll and not to keep source code due to size(200kb vs 19mb) and
> >> compile time reasons.
> >
> > Distributing the .dll without the source will *definitely* be a problem.
> > Distributing the .dll with the source *might* be a problem. The only way
> > we've been able to do this in the past (see Gradle and Crosswalk for two
> > recent examples) is to have a script that the user runs (even as part of
> > the platform scripts) that downloads the library from somewhere trusted
> and
> > installs it. We can't ship binaries as part of an Apache project.
> >
> >
> >>
> >> [1] https://github.com/apache/cordova-wp8/pull/62
> >>
> >> Thx!
> >> Sergey
> >>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> >> For additional commands, e-mail: dev-help@cordova.apache.org
> >>
> >>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>
>


-- 
Carlos Santana
<csantana23@gmail.com>

--e89a8ff1cf467f53d6051233c4ff--