Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
Received-SPF: pass (athena.apache.org: domain of nikhilkh@microsoft.com
 designates 65.55.169.105 as permitted sender)
From: Nikhil Khandelwal <nikhilkh@microsoft.com>
To: "dev@cordova.apache.org" <dev@cordova.apache.org>
Subject: RE: (Mobile spec) Replace dependency plugin with plugin list
 parameter in createmobilespec
Thread-Topic: (Mobile spec) Replace dependency plugin with plugin list
 parameter in createmobilespec
Thread-Index: AdBhcjm5TBiUk5QvSNygcEo1C8hgnAAHsZmwABCLmjA=
Date: Wed, 18 Mar 2015 23:34:07 +0000
Message-ID: 
 <BN1PR03MB139A269865084DDEFE277FEC3000@BN1PR03MB139.namprd03.prod.outlook.com>
References: 
 <CY1PR0301MB06042B48802275D02B23C4F796000@CY1PR0301MB0604.namprd03.prod.outlook.com>
 <957F1ECDA90E004B8DBDE23CFC94E3A3D2CACFB4@XMB111CNC.rim.net>
In-Reply-To: <957F1ECDA90E004B8DBDE23CFC94E3A3D2CACFB4@XMB111CNC.rim.net>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Mar 2015 23:34:07.5138
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1PR03MB139
X-Virus-Checked: Checked by ClamAV on apache.org

+1 for this improvement to createmobilespec.js.

As Josh pointed out, createmobilespec.js was testing plugin dependencies as=
 a side effect of its implementation detail. In fact, there was no specific=
 asserts or validation done to ensure that the plugin dependency feature wo=
rked.

Tests for plugin dependency should be tackled separately and designed purpo=
sefully.

Thanks,
Nikhil


-----Original Message-----
From: Josh Soref [mailto:jsoref@blackberry.com]=20
Sent: Wednesday, March 18, 2015 8:36 AM
To: dev@cordova.apache.org
Subject: RE: (Mobile spec) Replace dependency plugin with plugin list param=
eter in createmobilespec

One disadvantage of this is that it means plugin dependencies aren't
necessarily tested by most cordova developers.

The BlackBerry 10 default plugin system includes a couple of dependencies,
and plugin management has had a tendency to be fairly fragile/broken.

I'm not opposed to going this way, but if we do, then I'd request that ther=
e
be a dummy plugin with a dependency (actually, probably with a
grand-dependent too) just for the purposes of ensuring that default testing
covers these cases.

> -----Original Message-----
> From: Alexander Sorokin (Akvelon) [mailto:v-alsoro@microsoft.com]
> Sent: Wednesday, March 18, 2015 7:54 AM
> To: dev@cordova.apache.org
> Subject: (Mobile spec) Replace dependency plugin with plugin list
parameter
> in createmobilespec
>=20
> Hi guys,
>=20
> I would like to introduce a little improvement for mobile spec.
>=20
> Currently createmobilespec uses dependency plugin to specify the list of
> plugins to install. This approach has some limitations, for example after
the
> app is created the user cannot remove particular plugin because they all
are
> listed as dependencies of dependency plugin.
>=20
> Developers may want to add custom plugin(s) to mobile spec for testing.
Also
> some plugins could not be supported under particular platform and should
> not be installed.
>=20
> I've replaced dependency plugin with new command line parameter for
> createmobilespec to specify plugin list through CLI. If the parameter is
not
> passed, createmobilespec will use default list of plugins.
>=20
> This change would affect anyone who uses dependency plugin, though, so I
> ask a community to review my PR:
> https://github.com/apache/cordova-mobile-spec/pull/123/files
>=20
> Thanks,
> Alexander Sorokin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org