Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
Received-SPF: pass (nike.apache.org: domain of Tim.Barham@microsoft.com
 designates 157.56.111.147 as permitted sender)
From: Tim Barham <Tim.Barham@microsoft.com>
To: "dev@cordova.apache.org" <dev@cordova.apache.org>
Subject: RE: 'cordova plugin save' should also save plugin versions
Thread-Topic: 'cordova plugin save' should also save plugin versions
Thread-Index: 
 AQHQZkY85toLvTjYEEyfcfAcAYeaYZ0rwgWAgAAFtwCAACQWgIAAGfoAgAACNICAABKxgIAACVWAgAAVpg+AABPIAIAAELmAgAA1p4CAAKNJAIAAqlde
Date: Thu, 26 Mar 2015 00:04:05 +0000
Message-ID: 
 <A121B9C55062F74383A10254CBA1DB6F29595911@SINPRD3002MB008.064d.mgd.msft.net>
References: 
 <OF242A24DD.52E9EF89-ON85257E12.0053F82D-85257E12.005430BA@us.ibm.com>
 <CAK2avF8cTpmOnBg4kaqpnEm14FQOOs2+0v2W4eShwj2m6JnDRA@mail.gmail.com>
 <CA+X37cn_o9FCyW19XGrvS9r32js9G2wesYc1stX4TyxPdsLqrw@mail.gmail.com>
 <CABiQX1W0r1mMs+ZJF2FtdrOUiWmTZkLLUKSSPeiKJ=cJ49Wt9g@mail.gmail.com>
 <B030908C-603D-44F4-9392-429E717C3425@gmail.com>
 <D1370A8F.3007%byoungro.so@intel.com>
 <BN1PR03MB139D592A49AF2F3067B713CC30A0@BN1PR03MB139.namprd03.prod.outlook.com>
 <CAMSbhBhb9crMYK=2hL_ALZLbzHDHJk12Bfz0xwRw+3yCC8fCvg@mail.gmail.com>
 <A121B9C55062F74383A10254CBA1DB6F295911B8@SINPRD3002MB008.064d.mgd.msft.net>
 <941C7466-60E3-4BB3-8328-DF8C711C3820@gmail.com>
 <CABiQX1UGepjd1awmKe81LphHoaB1FYFv3Cmw8AZrvD2L-wTLiA@mail.gmail.com>
 <CAEeF2TcvPRMS6ZV+eLi1+ev=tC6QYhM72na_KXwpdc1WeaPqqA@mail.gmail.com>,<CABiQX1XGKR4CJ4qw085FVUKPVAAiw0Je7=DL+THWSqtPsbrVTA@mail.gmail.com>
In-Reply-To: 
 <CABiQX1XGKR4CJ4qw085FVUKPVAAiw0Je7=DL+THWSqtPsbrVTA@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Received-SPF: Pass (protection.outlook.com: domain of microsoft.com designates
 206.191.228.164 as permitted sender) receiver=protection.outlook.com;
 client-ip=206.191.228.164; helo=064-smtp-out.microsoft.com;
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Mar 2015 00:04:10.2510
 (UTC)
X-MS-Exchange-CrossTenant-Id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: 
 TenantId=72f988bf-86f1-41af-91ab-2d7cd011db47;Ip=[206.191.228.164];Helo=[064-smtp-out.microsoft.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0301MB0649
X-Virus-Checked: Checked by ClamAV on apache.org

I'd like to get input on how 'cordova platform save' and 'cordova plugin sa=
ve' commands (that save information about all installed platforms or plugin=
s to config.xml) should work with regard to modifying existing version info=
rmation in config.xml.

(Background: I'm updating the --save option when adding/updating a specific=
 platform or plugin to always write out the version being installed, using =
the "^x.x.x" notation. Consistent with 'npm install', I update an existing =
entry even if its version string would match what we're installing - so if =
the existing entry is '^3.2.1' and I'm installing '3.2.2', I update the ent=
ry to '^3.2.2').

My question is: Should we do the same with the 'platform save' and 'plugin =
save' commands: if there is an existing entry with a version that matches t=
he version that's installed, do we update it or leave it alone?

My feeling is to update it, since that behavior would be consistent with th=
e --save flag. But an argument could also be made that we should leave it a=
lone in this scenario.

Thanks!

Tim

________________________________________
From: agrieve@google.com [agrieve@google.com] on behalf of Andrew Grieve [a=
grieve@chromium.org]
Sent: Wednesday, March 25, 2015 11:44 PM
To: dev
Subject: Re: 'cordova plugin save' should also save plugin versions

That's what we already do (CPR *is* an npm database)

On Wed, Mar 25, 2015 at 12:00 AM, Michal Mocny <mmocny@chromium.org> wrote:

> ..Also with the move to put plugins in npm, I think we would be directly
> using npm's resolution of the version?
>
> On Tue, Mar 24, 2015 at 8:48 PM, Andrew Grieve <agrieve@chromium.org>
> wrote:
>
> > On Tue, Mar 24, 2015 at 7:48 PM, Gorkem Ercan <gorkem.ercan@gmail.com>
> > wrote:
> >
> > >
> > >
> > > On 24 Mar 2015, at 18:38, Tim Barham wrote:
> > >
> > >  +1 from me too (always save version, and allow automatic minor versi=
on
> > >> upgrades).
> > >>
> > >>  I like Andrew's idea, my only concern is implementing only a portio=
n
> of
> > > the semver syntax. I personally would assume full semver support afte=
r
> > > seeing "^1.2.3" notation on config.xml
> >
> > I think we do already support all semver? Just tried:
> >    cordova plugin add "cordova-plugin-okhttp@>1 <3"
> >  and it worked fine.
> >
> >
> > >
> > >
> > >  Gorkem - I'm currently doing some work in this area - I'm happy to
> make
> > >> this change while I'm there.
> > >>
> > >>  Sure, go ahead. I would not be able to get to it until next week.
> > >
> > >
> > >  ________________________________________
> > >> From: Steven Gill [stevengill97@gmail.com]
> > >> Sent: Wednesday, March 25, 2015 7:20 AM
> > >> To: dev@cordova.apache.org
> > >> Subject: Re: 'cordova plugin save' should also save plugin versions
> > >>
> > >> Definitely agree with alignment with npm's save! :D
> > >>
> > >> On Tue, Mar 24, 2015 at 1:46 PM, Nikhil Khandelwal <
> > >> nikhilkh@microsoft.com>
> > >> wrote:
> > >>
> > >>  I'm in favor of alignment of 'plugin save' behavior with npm's as w=
e
> > >>> expect developers to already familiar with that and in future, we
> plan
> > to
> > >>> move to npm.
> > >>>
> > >>> I liked Andrew's idea of adding a specific version with allowing
> minor
> > >>> version upgrades to be automatic.
> > >>>
> > >>> As for shrink wrapping, for npm this means locking down the version
> > >>> numbers of all modules and their dependencies:
> > >>> https://docs.npmjs.com/cli/shrinkwrap . It does not look our
> > >>> --shrinkwrap
> > >>> option does that.
> > >>>
> > >>> -Nikhil
> > >>>
> > >>> -----Original Message-----
> > >>> From: So, Byoungro [mailto:byoungro.so@intel.com]
> > >>> Sent: Tuesday, March 24, 2015 12:40 PM
> > >>> To: dev@cordova.apache.org
> > >>> Subject: Re: 'cordova plugin save' should also save plugin versions
> > >>>
> > >>> +1 for making the shrinkwrap as the default for the <save.
> > >>> This makes sure the users will restore the same version they saved
> > >>> before.
> > >>>
> > >>> Byoungro So
> > >>> SSG / DPD / Mobile Computing and Compilers Intel Corporation
> > >>>
> > >>>
> > >>>
> > >>>
> > >>>
> > >>>
> > >>> On 3/24/15, 12:31 PM, "Gorkem Ercan" <gorkem.ercan@gmail.com> wrote=
:
> > >>>
> > >>>
> > >>>> I think the problem here is shrinkwrap behaviour is the expected
> > >>>> because platforms behave that way. I guess we could just make
> > >>>> shrinkwrap default and change the flag to --noshrinkwrap.
> > >>>> --
> > >>>> Gorkem
> > >>>>
> > >>>> On 24 Mar 2015, at 13:58, Andrew Grieve wrote:
> > >>>>
> > >>>>  On Tue, Mar 24, 2015 at 11:49 AM, Gorkem Ercan
> > >>>>> <gorkem.ercan@gmail.com>
> > >>>>> wrote:
> > >>>>>
> > >>>>>  They are related but not same.
> > >>>>>>
> > >>>>>> CB-8594 asks to save the plugin version information during
> "cordova
> > >>>>>> plugin add --save". Right now we do not save version unless the
> > >>>>>> command is "cordova plugin add --save --shrinkwrap". This
> behaviour
> > >>>>>> allows plugins to be restored to the latest possible version
> > >>>>>> available if they are not explicitly shrinkwrapped.
> > >>>>>>
> > >>>>>>
> > >>>>> How about doing what npm does, and always save the version, but
> save
> > >>>>> it as "^1.0.3", so that you still get updates, but not major
> version
> > >>>>> changes?
> > >>>>>
> > >>>>>
> > >>>>>
> > >>>>>
> > >>>>>> As for CB-8733, "cordova plugin save" command can not save the
> > >>>>>> version information even if it had wanted to because fetch.json =
is
> > >>>>>> missing that information. It is a bug.
> > >>>>>> --
> > >>>>>> Gorkem
> > >>>>>>
> > >>>>>> On Tue, Mar 24, 2015 at 11:29 AM, Raymond Camden
> > >>>>>> <raymondcamden@gmail.com>
> > >>>>>> wrote:
> > >>>>>>
> > >>>>>>  Is that a dupe of https://issues.apache.org/jira/browse/CB-8594=
?
> > >>>>>>>
> > >>>>>>> On Tue, Mar 24, 2015 at 10:19 AM, Edna Y Morales
> > >>>>>>> <eymorale@us.ibm.com>
> > >>>>>>> wrote:
> > >>>>>>>
> > >>>>>>>>
> > >>>>>>>>
> > >>>>>>>> Currently, version info is not saved for plugins in the
> > fetch.json.
> > >>>>>>>>
> > >>>>>>> That
> > >>>>>>
> > >>>>>>> needs to be added so that plugin version can be saved in the
> > >>>>>>>>
> > >>>>>>> config.xml.
> > >>>>>>
> > >>>>>>> It
> > >>>>>>>
> > >>>>>>>> should follow what 'cordova platform save' does. I created a
> jira
> > >>>>>>>> item
> > >>>>>>>>
> > >>>>>>> for
> > >>>>>>>
> > >>>>>>>> this: https://issues.apache.org/jira/browse/CB-8733 and opened
> a
> > >>>>>>>> pull
> > >>>>>>>> request: https://github.com/apache/cordova-lib/pull/189. If
> > >>>>>>>> someone
> > >>>>>>>>
> > >>>>>>> could
> > >>>>>>>
> > >>>>>>>> review it and provide any feedback.
> > >>>>>>>>
> > >>>>>>>> Thanks,
> > >>>>>>>> Edna Morales
> > >>>>>>>>
> > >>>>>>>
> > >>>>>>>
> > >>>>>>>
> > >>>>>>> --
> > >>>>>>>
> > >>>>>>>
> > >>>>>>
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> > >>>>>> =3D=3D=3D
> > >>>>>> =3D=3D=3D
> > >>>>>>
> > >>>>>>> Raymond Camden, Developer Advocate for MobileFirst at IBM
> > >>>>>>>
> > >>>>>>> Email : raymondcamden@gmail.com
> > >>>>>>> Blog : www.raymondcamden.com
> > >>>>>>> Twitter: raymondcamden
> > >>>>>>>
> > >>>>>>>
> -------------------------------------------------------------------
> > >>>>>>> -- To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > >>>>>>> For additional commands, e-mail: dev-help@cordova.apache.org
> > >>>>>>>
> > >>>>>>>
> > >>>>>>>
> > >>>>>>
> > >>>>
> ---------------------------------------------------------------------
> > >>>> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > >>>> For additional commands, e-mail: dev-help@cordova.apache.org
> > >>>>
> > >>>>
> > >>>
> > >>> -------------------------------------------------------------------=
--
> > >>> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > >>> For additional commands, e-mail: dev-help@cordova.apache.org
> > >>>
> > >>>
> > >>> -------------------------------------------------------------------=
--
> > >>> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > >>> For additional commands, e-mail: dev-help@cordova.apache.org
> > >>>
> > >>>
> > >>>
> ---------------------------------------------------------------------
> > >> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > >> For additional commands, e-mail: dev-help@cordova.apache.org
> > >>
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > > For additional commands, e-mail: dev-help@cordova.apache.org
> > >
> > >
> >
>=

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org