Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
Received-SPF: pass (athena.apache.org: domain of Tim.Barham@microsoft.com
 designates 65.55.169.123 as permitted sender)
From: Tim Barham <Tim.Barham@microsoft.com>
To: "dev@cordova.apache.org" <dev@cordova.apache.org>
Subject: RE: 'cordova plugin save' should also save plugin versions
Thread-Topic: 'cordova plugin save' should also save plugin versions
Thread-Index: 
 AQHQZkY85toLvTjYEEyfcfAcAYeaYZ0rwgWAgAAFtwCAACQWgIAAGfoAgAACNICAABKxgIAACVWAgAAVpg8=
Date: Tue, 24 Mar 2015 22:38:50 +0000
Message-ID: 
 <A121B9C55062F74383A10254CBA1DB6F295911B8@SINPRD3002MB008.064d.mgd.msft.net>
References: 
 <OF242A24DD.52E9EF89-ON85257E12.0053F82D-85257E12.005430BA@us.ibm.com>
 <CAK2avF8cTpmOnBg4kaqpnEm14FQOOs2+0v2W4eShwj2m6JnDRA@mail.gmail.com>
 <CA+X37cn_o9FCyW19XGrvS9r32js9G2wesYc1stX4TyxPdsLqrw@mail.gmail.com>
 <CABiQX1W0r1mMs+ZJF2FtdrOUiWmTZkLLUKSSPeiKJ=cJ49Wt9g@mail.gmail.com>
 <B030908C-603D-44F4-9392-429E717C3425@gmail.com>
 <D1370A8F.3007%byoungro.so@intel.com>
 <BN1PR03MB139D592A49AF2F3067B713CC30A0@BN1PR03MB139.namprd03.prod.outlook.com>,<CAMSbhBhb9crMYK=2hL_ALZLbzHDHJk12Bfz0xwRw+3yCC8fCvg@mail.gmail.com>
In-Reply-To: 
 <CAMSbhBhb9crMYK=2hL_ALZLbzHDHJk12Bfz0xwRw+3yCC8fCvg@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Received-SPF: Pass (protection.outlook.com: domain of microsoft.com designates
 206.191.228.164 as permitted sender) receiver=protection.outlook.com;
 client-ip=206.191.228.164; helo=064-smtp-out.microsoft.com;
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2015 22:38:53.9462
 (UTC)
X-MS-Exchange-CrossTenant-Id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: 
 TenantId=72f988bf-86f1-41af-91ab-2d7cd011db47;Ip=[206.191.228.164];Helo=[064-smtp-out.microsoft.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR0301MB0671
X-Virus-Checked: Checked by ClamAV on apache.org

+1 from me too (always save version, and allow automatic minor version upgr=
ades).

Gorkem - I'm currently doing some work in this area - I'm happy to make thi=
s change while I'm there.

________________________________________
From: Steven Gill [stevengill97@gmail.com]
Sent: Wednesday, March 25, 2015 7:20 AM
To: dev@cordova.apache.org
Subject: Re: 'cordova plugin save' should also save plugin versions

Definitely agree with alignment with npm's save! :D

On Tue, Mar 24, 2015 at 1:46 PM, Nikhil Khandelwal <nikhilkh@microsoft.com>
wrote:

> I'm in favor of alignment of 'plugin save' behavior with npm's as we
> expect developers to already familiar with that and in future, we plan to
> move to npm.
>
> I liked Andrew's idea of adding a specific version with allowing minor
> version upgrades to be automatic.
>
> As for shrink wrapping, for npm this means locking down the version
> numbers of all modules and their dependencies:
> https://docs.npmjs.com/cli/shrinkwrap . It does not look our --shrinkwrap
> option does that.
>
> -Nikhil
>
> -----Original Message-----
> From: So, Byoungro [mailto:byoungro.so@intel.com]
> Sent: Tuesday, March 24, 2015 12:40 PM
> To: dev@cordova.apache.org
> Subject: Re: 'cordova plugin save' should also save plugin versions
>
> +1 for making the shrinkwrap as the default for the <save.
> This makes sure the users will restore the same version they saved before=
.
>
> Byoungro So
> SSG / DPD / Mobile Computing and Compilers Intel Corporation
>
>
>
>
>
>
> On 3/24/15, 12:31 PM, "Gorkem Ercan" <gorkem.ercan@gmail.com> wrote:
>
> >
> >I think the problem here is shrinkwrap behaviour is the expected
> >because platforms behave that way. I guess we could just make
> >shrinkwrap default and change the flag to --noshrinkwrap.
> >--
> >Gorkem
> >
> >On 24 Mar 2015, at 13:58, Andrew Grieve wrote:
> >
> >> On Tue, Mar 24, 2015 at 11:49 AM, Gorkem Ercan
> >> <gorkem.ercan@gmail.com>
> >> wrote:
> >>
> >>> They are related but not same.
> >>>
> >>> CB-8594 asks to save the plugin version information during "cordova
> >>> plugin add --save". Right now we do not save version unless the
> >>> command is "cordova plugin add --save --shrinkwrap". This behaviour
> >>> allows plugins to be restored to the latest possible version
> >>> available if they are not explicitly shrinkwrapped.
> >>>
> >>
> >> How about doing what npm does, and always save the version, but save
> >> it as "^1.0.3", so that you still get updates, but not major version
> >> changes?
> >>
> >>
> >>
> >>>
> >>> As for CB-8733, "cordova plugin save" command can not save the
> >>> version information even if it had wanted to because fetch.json is
> >>> missing that information. It is a bug.
> >>> --
> >>> Gorkem
> >>>
> >>> On Tue, Mar 24, 2015 at 11:29 AM, Raymond Camden
> >>> <raymondcamden@gmail.com>
> >>> wrote:
> >>>
> >>>> Is that a dupe of https://issues.apache.org/jira/browse/CB-8594?
> >>>>
> >>>> On Tue, Mar 24, 2015 at 10:19 AM, Edna Y Morales
> >>>> <eymorale@us.ibm.com>
> >>>> wrote:
> >>>>>
> >>>>>
> >>>>> Currently, version info is not saved for plugins in the fetch.json.
> >>> That
> >>>>> needs to be added so that plugin version can be saved in the
> >>> config.xml.
> >>>> It
> >>>>> should follow what 'cordova platform save' does. I created a jira
> >>>>> item
> >>>> for
> >>>>> this: https://issues.apache.org/jira/browse/CB-8733 and opened a
> >>>>> pull
> >>>>> request: https://github.com/apache/cordova-lib/pull/189. If
> >>>>> someone
> >>>> could
> >>>>> review it and provide any feedback.
> >>>>>
> >>>>> Thanks,
> >>>>> Edna Morales
> >>>>
> >>>>
> >>>>
> >>>> --
> >>>>
> >>>
> >>>=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> >>>=3D=3D=3D
> >>>=3D=3D=3D
> >>>> Raymond Camden, Developer Advocate for MobileFirst at IBM
> >>>>
> >>>> Email : raymondcamden@gmail.com
> >>>> Blog : www.raymondcamden.com
> >>>> Twitter: raymondcamden
> >>>>
> >>>> -------------------------------------------------------------------
> >>>> -- To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> >>>> For additional commands, e-mail: dev-help@cordova.apache.org
> >>>>
> >>>>
> >>>
> >
> >---------------------------------------------------------------------
> >To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> >For additional commands, e-mail: dev-help@cordova.apache.org
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>
>=

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org