Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: AlexTalis <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-43-cordova-plugin-splashscreen@git.apache.org>
In-Reply-To: <git-pr-43-cordova-plugin-splashscreen@git.apache.org>
Subject: [GitHub] cordova-plugin-splashscreen pull request: CB-8753 Maintain
 splash ...
Content-Type: text/plain
Message-Id: <20150330234209.4885BE1081@git1-us-west.apache.org>
Date: Mon, 30 Mar 2015 23:42:09 +0000 (UTC)

Github user AlexTalis commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-splashscreen/pull/43#discussion_r27442565
  
    --- Diff: src/android/SplashScreen.java ---
    @@ -194,9 +263,25 @@ public void run() {
                     // TODO: Use the background color of the webView's parent instead of using the
                     // preference.
                     root.setBackgroundColor(preferences.getInteger("backgroundColor", Color.BLACK));
    +                
                     root.setLayoutParams(new LinearLayout.LayoutParams(ViewGroup.LayoutParams.MATCH_PARENT,
                             ViewGroup.LayoutParams.MATCH_PARENT, 0.0F));
    -                root.setBackgroundResource(drawableId);
    +                
    +                // Use an ImageView to render the image because of its flexible scaling options.
    +                splashImageView = new ImageView(context);
    +                splashImageView.setImageResource(drawableId);
    --- End diff --
    
    I added a loop in JS to slow down the app. It calls console.log a bunch of times. I hard-coded BG color to RED and tested the app with and without the linear layout. I never see RED in either view hierarchy. When the app is slow, I just see black background when layout/painting is lagging.
    
    ![image](https://cloud.githubusercontent.com/assets/1012600/6909507/ad513bf8-d6fb-11e4-9146-e3f46a151912.png)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org