Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: kant2002 <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-15-cordova-plugins@git.apache.org>
In-Reply-To: <git-pr-15-cordova-plugins@git.apache.org>
Subject: [GitHub] cordova-plugins pull request: CB-6289 Keyboard plugin on
 Android
Content-Type: text/plain
Message-Id: <20150330154045.8F514E0FC5@git1-us-west.apache.org>
Date: Mon, 30 Mar 2015 15:40:45 +0000 (UTC)

Github user kant2002 commented on a diff in the pull request:

    https://github.com/apache/cordova-plugins/pull/15#discussion_r27401690
  
    --- Diff: keyboard/src/android/Keyboard.java ---
    @@ -0,0 +1,124 @@
    +/*
    +       Licensed to the Apache Software Foundation (ASF) under one
    +       or more contributor license agreements.  See the NOTICE file
    +       distributed with this work for additional information
    +       regarding copyright ownership.  The ASF licenses this file
    +       to you under the Apache License, Version 2.0 (the
    +       "License"); you may not use this file except in compliance
    +       with the License.  You may obtain a copy of the License at
    +
    +         http://www.apache.org/licenses/LICENSE-2.0
    +
    +       Unless required by applicable law or agreed to in writing,
    +       software distributed under the License is distributed on an
    +       "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +       KIND, either express or implied.  See the License for the
    +       specific language governing permissions and limitations
    +       under the License.
    +*/
    +package org.apache.cordova.labs.keyboard; 
    +
    +import org.apache.cordova.CallbackContext;
    +import org.apache.cordova.CordovaInterface;
    +import org.apache.cordova.CordovaPlugin;
    +import org.apache.cordova.CordovaWebView;
    +import org.apache.cordova.LOG;
    +import org.json.JSONArray;
    +import org.json.JSONException;
    +
    +import android.app.Activity;
    +import android.content.Context;
    +import android.graphics.Rect;
    +import android.util.DisplayMetrics;
    +import android.view.View;
    +import android.view.ViewTreeObserver.OnGlobalLayoutListener;
    +import android.view.inputmethod.InputMethodManager;
    +
    +public class Keyboard extends CordovaPlugin {
    +    /**
    +    * Delta height of the visible area, to be treated as keyboard opening.
    +    */
    +    private final static int MinHeghtDelta = 100;
    +    private static final String TAG = "Keyboard";
    +
    +    public void initialize(CordovaInterface cordova, CordovaWebView webView) {
    +        super.initialize(cordova, webView);
    +        
    +        Activity activity = cordova.getActivity();
    +        DisplayMetrics metrics = new DisplayMetrics();
    +        activity.getWindowManager().getDefaultDisplay().getMetrics(metrics);
    +        final float density = metrics.density;
    +        
    +        final CordovaWebView appView = webView;
    +        
    +        final View rootView = activity.getWindow().getDecorView().findViewById(android.R.id.content).getRootView();
    +        OnGlobalLayoutListener list = new OnGlobalLayoutListener() {
    +            int previousHeightDifference = 0;
    +            
    +            @Override
    +            public void onGlobalLayout() {
    +                LOG.d(TAG, "Entering global layout notification");
    +                
    +            	Rect visibleRect = new Rect();
    +                //r will be populated with the coordinates of your view that area still visible.
    +                rootView.getWindowVisibleDisplayFrame(visibleRect);
    +
    +                int visibleHeight = visibleRect.bottom - visibleRect.top;
    +                int viewHeight = rootView.getRootView().getHeight();
    +                int heightDifference = (int)((viewHeight - visibleHeight) / density);
    +                if (heightDifference > MinHeghtDelta 
    +                    && heightDifference != previousHeightDifference) {
    +                    // If the height of the view is bigger then 
    +                    // visible area by delta, then assume that keyboard
    +                    // is shown on the screen.
    +                    appView.sendJavascript("Keyboard.isVisible = true; if (Keyboard.onshow) Keyboard.onshow();");
    --- End diff --
    
    Could you give me a bit of insight between the differences between `setKeepCallback(true)` and `setKeepCallback(false)`. Are there any benefit from having keeping callback? I don't closely follow design decisions in the Cordova lately, so cant make rational decision.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org