Return-Path: 
 <dev-return-44340-apmail-cordova-dev-archive=cordova.apache.org@cordova.apache.org>
X-Original-To: apmail-cordova-dev-archive@www.apache.org
Delivered-To: apmail-cordova-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 674A217D4F
	for <apmail-cordova-dev-archive@www.apache.org>;
 Fri, 27 Mar 2015 14:23:18 +0000 (UTC)
Received: (qmail 34010 invoked by uid 500); 27 Mar 2015 14:23:18 -0000
Delivered-To: apmail-cordova-dev-archive@cordova.apache.org
Received: (qmail 33973 invoked by uid 500); 27 Mar 2015 14:23:18 -0000
Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@cordova.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@cordova.apache.org>
List-Post: <mailto:dev@cordova.apache.org>
List-Id: <dev.cordova.apache.org>
Reply-To: dev@cordova.apache.org
Delivered-To: mailing list dev@cordova.apache.org
Received: (qmail 33897 invoked by uid 99); 27 Mar 2015 14:23:17 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 27 Mar 2015 14:23:17 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id BB0EAE2F05; Fri, 27 Mar 2015 14:23:17 +0000 (UTC)
From: agrieve <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-194-cordova-lib@git.apache.org>
In-Reply-To: <git-pr-194-cordova-lib@git.apache.org>
Subject: [GitHub] cordova-lib pull request: CB-8754 Auto-restoring a plugin
 fails wh...
Content-Type: text/plain
Message-Id: <20150327142317.BB0EAE2F05@git1-us-west.apache.org>
Date: Fri, 27 Mar 2015 14:23:17 +0000 (UTC)

Github user agrieve commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/194#discussion_r27298165
  
    --- Diff: cordova-lib/src/plugman/registry/registry.js ---
    @@ -223,11 +211,13 @@ module.exports = {
      * @param {Boolean} determines if we are using the npm registry
      * @return {Promise.<Object>} Promised settings.
      */
    -function initSettings() {
    +function initSettings(returnEmptySettings) {
         var settings = module.exports.settings;
     
         // check if settings already set
    -    if(settings !== null) return Q(settings);
    +    if(settings !== null) {
    --- End diff --
    
    This returns settings even when returnEmptySettings is true. should it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org