Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 93C8117A08 for ; Thu, 12 Mar 2015 09:33:50 +0000 (UTC) Received: (qmail 35075 invoked by uid 500); 12 Mar 2015 09:33:44 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 35038 invoked by uid 500); 12 Mar 2015 09:33:44 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 35027 invoked by uid 99); 12 Mar 2015 09:33:43 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 Mar 2015 09:33:43 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 49484E18D3; Thu, 12 Mar 2015 09:33:43 +0000 (UTC) From: sandstrom To: dev@cordova.apache.org Reply-To: dev@cordova.apache.org References: In-Reply-To: Subject: [GitHub] cordova-plugin-geolocation pull request: CB-7754 - [Geolocation] S... Content-Type: text/plain Message-Id: <20150312093343.49484E18D3@git1-us-west.apache.org> Date: Thu, 12 Mar 2015 09:33:43 +0000 (UTC) Github user sandstrom commented on the pull request: https://github.com/apache/cordova-plugin-geolocation/pull/28#issuecomment-78448058 Any existing value for `NSLocationAlwaysUsageDescription ` in the plist gets overwritten with an empty string. This makes it harder to provide a custom description (which is the purpose of the string, btw). Don't know if the plugin facility allows, but if it could handle this 'softly', e.g. only add the key to the plist unless it already exists, that would solve it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org For additional commands, e-mail: dev-help@cordova.apache.org