Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: omefire <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-182-cordova-lib@git.apache.org>
In-Reply-To: <git-pr-182-cordova-lib@git.apache.org>
Subject: [GitHub] cordova-lib pull request: Deprecate the old feature syntax
 from co...
Content-Type: text/plain
Message-Id: <20150310015446.351E9E1831@git1-us-west.apache.org>
Date: Tue, 10 Mar 2015 01:54:46 +0000 (UTC)

Github user omefire commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/182#discussion_r26093910
  
    --- Diff: cordova-lib/spec-cordova/ConfigParser.spec.js ---
    @@ -114,78 +114,94 @@ describe('config.xml parser', function () {
                     expect(cfg.getPlatformPreference('orientation', 'foobar')).toEqual('');
                 });
             });
    -        describe('feature',function(){
    -            it('should read feature id list', function() {
    +        describe('plugin',function(){
    +            it('should read plugin id list', function() {
                    var expectedList = [
                        'org.apache.cordova.featurewithvars',
                        'org.apache.cordova.featurewithurl',
                        'org.apache.cordova.featurewithversion',
                        'org.apache.cordova.featurewithurlandversion',
    -                   'org.apache.cordova.justafeature'
    +                   'org.apache.cordova.justafeature',
    +                   'org.apache.cordova.legacyfeature'
                    ];
    -               var list = cfg.getFeatureIdList();
    +               var list = cfg.getPluginIdList();
                    expect(list.length).toEqual(expectedList.length);
    -               expectedList.forEach(function(feature){
    -                   expect(list).toContain(feature);
    +               expectedList.forEach(function(plugin){
    +               expect(list).toContain(plugin);
    --- End diff --
    
    :nit please indent this line.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org