Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: agrieve <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-175-cordova-lib@git.apache.org>
In-Reply-To: <git-pr-175-cordova-lib@git.apache.org>
Subject: [GitHub] cordova-lib pull request: CB-8551 npm registry integration
 for fet...
Content-Type: text/plain
Message-Id: <20150303142531.7CFAFE07F3@git1-us-west.apache.org>
Date: Tue,  3 Mar 2015 14:25:31 +0000 (UTC)

Github user agrieve commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/175#discussion_r25690407
  
    --- Diff: cordova-lib/src/plugman/fetch.js ---
    @@ -147,6 +146,9 @@ function fetchPlugin(plugin_src, plugins_dir, options) {
             checkID(options.expected_id, result.pinfo);
             metadata.save_fetch_metadata(plugins_dir, result.pinfo.id, { source: result.fetchJsonSource });
             return result.dest;
    +    })            
    +    .fail(function(error) {
    --- End diff --
    
    This is a no-op, is it not?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org