Return-Path: 
 <dev-return-43205-apmail-cordova-dev-archive=cordova.apache.org@cordova.apache.org>
X-Original-To: apmail-cordova-dev-archive@www.apache.org
Delivered-To: apmail-cordova-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 976D3108EA
	for <apmail-cordova-dev-archive@www.apache.org>;
 Tue,  3 Mar 2015 09:10:04 +0000 (UTC)
Received: (qmail 38024 invoked by uid 500); 3 Mar 2015 09:10:04 -0000
Delivered-To: apmail-cordova-dev-archive@cordova.apache.org
Received: (qmail 37977 invoked by uid 500); 3 Mar 2015 09:10:04 -0000
Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@cordova.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@cordova.apache.org>
List-Post: <mailto:dev@cordova.apache.org>
List-Id: <dev.cordova.apache.org>
Reply-To: dev@cordova.apache.org
Delivered-To: mailing list dev@cordova.apache.org
Received: (qmail 37965 invoked by uid 99); 3 Mar 2015 09:10:04 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Mar 2015 09:10:04 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id CEAECE03B9; Tue,  3 Mar 2015 09:10:03 +0000 (UTC)
From: TimBarham <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-175-cordova-lib@git.apache.org>
In-Reply-To: <git-pr-175-cordova-lib@git.apache.org>
Subject: [GitHub] cordova-lib pull request: CB-8551 npm registry integration
 for fet...
Content-Type: text/plain
Message-Id: <20150303091003.CEAECE03B9@git1-us-west.apache.org>
Date: Tue,  3 Mar 2015 09:10:03 +0000 (UTC)

Github user TimBarham commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/175#discussion_r25671898
  
    --- Diff: cordova-lib/src/plugman/registry/registry.js ---
    @@ -218,10 +205,18 @@ module.exports = {
     
     /**
      * @method initSettings
    + * @param {Boolean} using npm registry
      * @return {Promise.<Object>} Promised settings.
      */
    -function initSettings() {
    +function initSettings(npm) {
         var settings = module.exports.settings;
    +    var registryURL = 'http://registry.cordova.io';
    +
    +    //if npm is true, use npm registry
    +    if(npm) {
    +        registryURL = 'http://registry.npmjs.org';
    +    }
    +
    --- End diff --
    
    Minor nit - rather than setting registryURL to one value, then potentially setting it to another value, why not just:
    
        var registryURL = npm ? 'http://registry.npmjs.org' : 'http://registry.cordova.io';


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org