Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
Received-SPF: pass (nike.apache.org: domain of Rob.Paveza@microsoft.com
 designates 64.4.22.89 as permitted sender)
From: Rob Paveza <Rob.Paveza@microsoft.com>
To: "dev@cordova.apache.org" <dev@cordova.apache.org>
Subject: RE: [GitHub] cordova-windows pull request: Fix for callback
 invocation with NO_...
Thread-Topic: [GitHub] cordova-windows pull request: Fix for callback
 invocation with NO_...
Thread-Index: AQHQXGINWTHBlzq7RUCS6dbbnGh+2p0Y1COA//+LYTA=
Date: Thu, 12 Mar 2015 06:17:06 +0000
Message-ID: 
 <073f22be8c954fc597ab080d993df8e8@DFM-DB3MBX15-05.exchange.corp.microsoft.com>
References: <git-pr-61-cordova-windows@git.apache.org>
 <20150312061421.BF977E18C3@git1-us-west.apache.org>
In-Reply-To: <20150312061421.BF977E18C3@git1-us-west.apache.org>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Received-SPF: Pass (protection.outlook.com: domain of microsoft.com designates
 131.107.159.100 as permitted sender) receiver=protection.outlook.com;
 client-ip=131.107.159.100; helo=hybrid.exchange.microsoft.com;
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Mar 2015 06:17:14.8089
 (UTC)
X-MS-Exchange-CrossTenant-Id: f686d426-8d16-42db-81b7-ab578e110ccd
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: 
 TenantId=f686d426-8d16-42db-81b7-ab578e110ccd;Ip=[131.107.159.100];Helo=[hybrid.exchange.microsoft.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2SR01MB605
X-Virus-Checked: Checked by ClamAV on apache.org

Only question is if callback.status might be undefined (stands to reason if=
 it can be null).  If so, the present check is insufficient and changes bec=
ause you test with =3D=3D=3D.

-Rob

-----Original Message-----
From: robpaveza [mailto:git@git.apache.org]=20
Sent: Wednesday, March 11, 2015 11:14 PM
To: dev@cordova.apache.org
Subject: [GitHub] cordova-windows pull request: Fix for callback invocation=
 with NO_...

Github user robpaveza commented on a diff in the pull request:

    https://github.com/apache/cordova-windows/pull/61#discussion_r26280733
 =20
    --- Diff: cordova-js-src/exec.js ---
    @@ -60,18 +60,32 @@ module.exports =3D function (success, fail, service=
, action, args) {
                 // CB-5806 [Windows8] Add keepCallback support to proxy
                 onSuccess =3D function (result, callbackOptions) {
                     callbackOptions =3D callbackOptions || {};
    +                var callbackStatus;
    +                if (callbackOptions.status !=3D=3D null) {
    --- End diff --
   =20
    Is undefined a possible value here?


---
If your project is set up for it, you can reply to this email and have your=
 reply appear on GitHub as well. If your project does not have this feature=
 enabled and wishes so, or if the feature is enabled but not working, pleas=
e contact infrastructure at infrastructure@apache.org or file a JIRA ticket=
 with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org