cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robpaveza <...@git.apache.org>
Subject [GitHub] cordova-windows pull request: CB8673: Initial orientation settings
Date Sat, 14 Mar 2015 00:09:09 GMT
GitHub user robpaveza opened a pull request:

    https://github.com/apache/cordova-windows/pull/63

    CB8673: Initial orientation settings

    This feature had already been done so I took the opportunity to clean up the
    existing code.  There were multiple cases where the code scanned
    multiple times (in worst case) for an element or set of elements,
    for example.  This associates an XML namespace prefix with each
    app manifest, so there's no need to map file name to Windows
    platform version to prefix.  It's just in the data.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/robpaveza/cordova-windows CB8673

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-windows/pull/63.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #63
    
----
commit 37c0506d5a3dfeb99c9b4472084bd1824b1805d8
Author: Rob Paveza <rob.paveza@microsoft.com>
Date:   2015-03-13T23:51:39Z

    CB8673: Initial orientation settings
    This had already been done so I took the opportunity to clean up the
    existing code.  There were multiple cases where the code scanned
    multiple times (in worst case) for an element or set of elements,
    for example.  This associates an XML namespace prefix with each
    app manifest, so there's no need to map file name to Windows
    platform version to prefix.  It's just in the data.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message