cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dpolivy <...@git.apache.org>
Subject [GitHub] cordova-plugin-splashscreen pull request: CB-8750 [wp8]: Allow res...
Date Thu, 26 Mar 2015 18:30:49 GMT
GitHub user dpolivy opened a pull request:

    https://github.com/apache/cordova-plugin-splashscreen/pull/41

    CB-8750 [wp8]: Allow resolution-specific splashscreen images

    There are two aspect ratios for Windows Phone devices: 15:9 and 16:9. At
    the moment, though, there is only one splash screen by default for WP8
    Cordova apps. When stretched to fit all possible resolutions, this can
    sometimes look bad.
    
    WP supports resolution-specific splashscreens, so this commit adds the
    same support to the splashscreen plugin. It uses the same base name for
    the splashscreen, but adds modifiers such as ".screen-<res>" based on
    the device. If a screen-specific image is found, it is used. If not, we
    fall back to the single default image.
    
    Fixes https://issues.apache.org/jira/browse/CB-8750

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dpolivy/cordova-plugin-splashscreen CB8750

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-splashscreen/pull/41.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #41
    
----
commit 542cf56240ae19592bdba2ee67b61a0325eadd00
Author: Dan Polivy <dan@cellartracker.com>
Date:   2015-03-26T18:29:50Z

    CB-8750 [wp8]: Allow resolution-specific splashscreen images
    
    There are two aspect ratios for Windows Phone devices: 15:9 and 16:9. At
    the moment, though, there is only one splash screen by default for WP8
    Cordova apps. When stretched to fit all possible resolutions, this can
    sometimes look bad.
    
    WP supports resolution-specific splashscreens, so this commit adds the
    same support to the splashscreen plugin. It uses the same base name for
    the splashscreen, but adds modifiers such as ".screen-<res>" based on
    the device. If a screen-specific image is found, it is used. If not, we
    fall back to the single default image.
    
    Fixes https://issues.apache.org/jira/browse/CB-8750

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message