cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From TimBarham <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-8651 Restoring platforms causes plugi...
Date Fri, 27 Mar 2015 13:49:06 GMT
GitHub user TimBarham opened a pull request:

    https://github.com/apache/cordova-lib/pull/196

    CB-8651 Restoring platforms causes plugin install to be triggered twice.

    If you add a platform and there are plugins listed in `config.xml`, those plugins get
added twice. Once during `prepare()`, when we add all plugins listed in `config.xml`, and
once in `platform.add()`, when we add all installed plugins to the new platform.
    
    Both these cases are needed in different scenarios, so the easiest fix seemed to be to
check for and ignore plugins that have already been installed for a platform, in `installPluginsForNewPlatform()`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-lib CB-8651

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/196.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #196
    
----
commit defba38ed74f4af4ed25aeee80baeaf77f42e4ee
Author: Tim Barham <tim.barham@microsoft.com>
Date:   2015-03-27T13:45:15Z

    CB-8651 Restoring platforms causes plugin install to be triggered twice.
    
    If you add a platform and there are plugins listed in config.xml, those plugins get added
twice. One during prepare(), when we add all plugins listed in config.xml, and once in platform.add(),
when we add all installed plugins to the new platform.
    
    Both these cases are needed in different scenarios, so the easiest fix seemed to be to
check for and ignore plugins that have already been installed for a platform, in installPluginsForNewPlatform().

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message