cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From TimBarham <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-8670 Error when set engine name to "c...
Date Fri, 13 Mar 2015 12:36:42 GMT
GitHub user TimBarham opened a pull request:

    https://github.com/apache/cordova-lib/pull/185

    CB-8670 Error when set engine name to "cordova-windows" in plugin.xml

    If you create an `engine` element with `name="cordova-windows"` (rather than `cordova-windows8`)
in `plugin.xml`, like this:
    
    ```xml
    <engines>
        <engine name="cordova-windows" version=">=3.8.0" />
    </engines>
    ```
    
    You will get an error when you add the plugin:
    
    ```
    TypeError: Cannot call method 'indexOf' of undefined
        at ...\cordova-lib\src\plugman\install.js:232:45
    ```
    
    The engines in `default-engines.js` had not been updated to support `cordova-windows`
as a platform name.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-lib CB-8670

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/185.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #185
    
----
commit 301d7381c323172b028875ac672c4298ed0d0bbc
Author: Tim Barham <tim.barham@microsoft.com>
Date:   2015-03-13T12:25:03Z

    CB-8670 Error when set engine name to "cordova-windows" in plugin.xml
    
    If you create an engine element with name="cordova-windows" in plugin.xml, like this:
    
    <engines>
        <engine name="cordova-windows" version=">=3.8.0" />
    </engines>
    
    You will get an error when you add the plugin:
    
    TypeError: Cannot call method 'indexOf' of undefined
        at ...\cordova-lib\src\plugman\install.js:232:45

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message