cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From thehuijb <...@git.apache.org>
Subject [GitHub] cordova-android pull request: solves CB-8768 issue where onActivit...
Date Tue, 31 Mar 2015 06:32:45 GMT
GitHub user thehuijb opened a pull request:

    https://github.com/apache/cordova-android/pull/171

    solves CB-8768 issue where onActivityResult gets called before onResume after MainActivity
gets killed

    situation: one of the plugins launches startActivityForResult and the Android OS decides
to kill our MainActivity.
    once the launched activity is fulfilled it comes back to our MainActivity, which has to
be recreated first.
    unfortunately Android calls onActivityResult before our Activity has fully loaded our
installed plugins.
    
    this commit fixes that issue. thanks to suggestions by Andrew Grieve

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/thehuijb/cordova-android develop

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-android/pull/171.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #171
    
----
commit a9d0a6f133f049807ad796b11b0f3e13644725c7
Author: Serge Huijben <s.huijben@gmail.com>
Date:   2015-03-31T06:28:13Z

    solves CB-8768 issue where onActivityResult while plugins are not yet fully loaded after
MainActivity gets killed
    
    situation: one of the plugins launches startActivityForResult and the Android OS decides
to kill our MainActivity.
    once the launched activity is fulfilled it comes back to our MainActivity, which has to
be recreated first.
    unfortunately Android calls onActivityResult before our Activity has fully loaded our
installed plugins.
    
    this commit fixes that issue. thanks to suggestions by Andrew Grieve

commit dceddf3c4e254c1649ddd376e8ff33db822adaca
Author: Serge Huijben <s.huijben@gmail.com>
Date:   2015-03-31T06:28:13Z

    solves CB-8768 issue where onActivityResult while plugins are not yet fully loaded after
MainActivity gets killed
    
    situation: one of the plugins launches startActivityForResult and the Android OS decides
to kill our MainActivity.
    once the launched activity is fulfilled it comes back to our MainActivity, which has to
be recreated first.
    unfortunately Android calls onActivityResult before our Activity has fully loaded our
installed plugins.
    
    this commit fixes that issue. thanks to suggestions by Andrew Grieve

commit 4ca329d5bf09ebbc8e4dd090aa5a663acb65df6c
Author: Serge Huijben <s.huijben@gmail.com>
Date:   2015-03-31T06:29:40Z

    Merge branch 'develop' of https://github.com/thehuijb/cordova-android into develop
    
    * 'develop' of https://github.com/thehuijb/cordova-android:
      solves CB-8768 issue where onActivityResult while plugins are not yet fully loaded after
MainActivity gets killed

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message