cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vldmrrr <...@git.apache.org>
Subject [GitHub] cordova-plugin-file pull request: CB-8728 fix write after seek on ...
Date Fri, 20 Mar 2015 21:41:37 GMT
GitHub user vldmrrr opened a pull request:

    https://github.com/apache/cordova-plugin-file/pull/106

    CB-8728 fix write after seek on windows

    write operation of FileWriter overwrites completely contents of existing file after write
position was set by seek function. Automated tests for plugin only verify the length of writer
object, but do not check the actual data written to file.
    
    Changes included for code and tests.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vldmrrr/cordova-plugin-file CB-8728

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-file/pull/106.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #106
    
----
commit ad64f0e03e33c6cf96d732f4b6dd0f8ba14d375b
Author: unknown <vldmrrr@gmail.com>
Date:   2015-03-20T21:36:04Z

    Use position set by seek when writing data.

commit 5c60410791873261065690123eab1a462d8271c6
Author: unknown <vldmrrr@gmail.com>
Date:   2015-03-20T21:36:44Z

    Verify data in tests for write after seek.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message