cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mgcrea <...@git.apache.org>
Subject [GitHub] cordova-plugin-file pull request: fix(ios): always use setters to ...
Date Fri, 13 Mar 2015 12:00:06 GMT
GitHub user mgcrea opened a pull request:

    https://github.com/apache/cordova-plugin-file/pull/104

    fix(ios): always use setters to fix memory issues without ARC

    Encountered memory issues with a non-ARC project (cordova+unity3d). Setter should be used
to prevent memory issues, eg:
    
    A synthesized retained setter looks like :
    
    ```
    - (void)setValue: (id)newValue
    {
        if (value != newValue)
        {
            [value release];
            value = newValue;
            [value retain];
        }
    } 
    ```

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mgcrea/cordova-plugin-file master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-file/pull/104.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #104
    
----
commit 90d4d51c7bc229f86a2c36ccc56ad8b08ebd5292
Author: Olivier Louvignes <olivier@mg-crea.com>
Date:   2015-03-13T11:57:37Z

    fix(ios): always use setters to fix memory issues without ARC

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message