cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rob Paveza <Rob.Pav...@microsoft.com>
Subject RE: Consolidating platform specific code from different places in cordova-lib
Date Wed, 11 Mar 2015 17:59:25 GMT
LGTM.  Only weird thing is that the platforms lib is in '../platforms/platforms' moved from
just '../platforms' - but not a big deal in the least.

-----Original Message-----
From: mmocny@google.com [mailto:mmocny@google.com] On Behalf Of Michal Mocny
Sent: Wednesday, March 11, 2015 7:29 AM
To: dev
Subject: Re: Consolidating platform specific code from different places in cordova-lib

Reviewed, left comments.  Overall looks good, thanks Mark.

However, seems you left something uncommitted, since you literally cannot require('cordova-lib');
without an exception thrown.  Yet all the cordova-lib tests pass.  What does it say about
the quality of the tests ;)

On Tue, Mar 10, 2015 at 6:24 PM, Jesse <purplecabbage@gmail.com> wrote:

> Had a quick look, looks great!
>
> @purplecabbage
> risingj.com
>
> On Tue, Mar 10, 2015 at 3:09 PM, Mark Koudritsky <kamrik@google.com>
> wrote:
>
> > I've created a pull request with changes across cordova-lib that 
> > should make it much easier to consolidate the platform specific code 
> > in cordova-lib to reduce duplication and maybe eventually move this 
> > code to the platforms repos.
> >
> > https://github.com/apache/cordova-lib/pull/183
> > Feedback is welcome.
> >
> > Those changes only deal with interfacing the platform specific code 
> > from cordova/metadata/ and plugman/platforms/ dirs, the dirs 
> > themselves and their contents weren't changed yet.
> >
>
Mime
View raw message