cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ian Clelland <iclell...@chromium.org>
Subject Re: [DISCUSS] Cordova-Android 4.0.0 Release
Date Tue, 03 Mar 2015 03:52:54 GMT
On Mon, Mar 2, 2015 at 6:00 PM, Jesse <purplecabbage@gmail.com> wrote:

> We should start a new whitelist plugin related thread.
>
> Why is a plugin blocking a release?  Default (aka no-plugin) behavior
> should be to allow all network requests shouldn't it?


Well, that just might be a blacklist then :)


>   This thread is a
> month long, and not the first discussion of 4.0.0 for Android.
>

Seriously, though -- the whitelist discussion is much longer than that, and
this isn't the first time that the default no-network-access policy has
been brought up:

(Here's the first question, from *July*:
http://markmail.org/message/t4vj4saisem2mcgw
Here's where I mentioned what the implemented policy was:
http://markmail.org/message/s4necfnh4hnblpjm
And in another discussion: http://markmail.org/message/ap7syhqysizmsvrz)

If we want to reconsider that decision, then we should certainly do so
before we cut a release. I think it would be a real problem to change it
afterwards, so let's get it right.

Also, it's not the plugin itself that's blocking the release, it's us
making sure that we've implemented the core hooks correctly so that the
plugin can actually do its job, and that people who don't want that
particular plugin can make a better one.

(It is also an issue that a plugin, required for cordova-android 4.0.0,
breaks apps which are also building for cordova-ios 3.8.0. I'll take a look
at that, and either remove the ios-native portions of the whitelist plugin,
or neuter it so that it doesn't interfere with an ios app if it's not on
the unplug-whitelist branch of that repo.)

Ian


> @purplecabbage
> risingj.com
>
> On Mon, Mar 2, 2015 at 2:02 PM, Shazron <shazron@gmail.com> wrote:
>
> > legacy-whitelist-plugin should be fixed so that it compiles on
> > cordova-ios@3.8.0. It shouldn't be a problem to fix this at compile or
> > run-time (whichever is applicable here related to the compile error)
> >
> > On Mon, Mar 2, 2015 at 1:47 PM, Darryl Pogue <dvpdiner2@gmail.com>
> wrote:
> > > On 2 March 2015 at 13:37, Joe Bowser <bowserj@gmail.com> wrote:
> > >> So, right now the whitelist changes are what's holding up the 4.0.0
> > release
> > >> now?  Is this really the only thing that's holding up this release?
> > >>
> > >> On Wed Feb 25 2015 at 1:18:26 PM Andrew Grieve <agrieve@chromium.org>
> > wrote:
> > >>
> > >>> I think we'll also need to finish with the whitelist changes &
have
> > both
> > >>> the legacy and new-way whitelist plugins released before we can do
a
> > 4.0.0
> > >>> release (otherwise you wouldn't be able to write an app that hits the
> > >>> network)
> > >>>
> > >
> > > Just FYI, the whitelist stuff is proving to be a bit of a pain point.
> > > I'm using cordova-android@master, and need to install the
> > > legacy-whitelist plugin in order to make network requests. Once the
> > > plugin is installed, everything seems to work.
> > >
> > > The problem is that the legacy-whitelist plugin generates compile
> > > errors with cordova-ios@3.8.0, so now I can't just run `cordova
> > > build`, I need to split the platforms up and install/uninstall the
> > > plugin in between. If someone makes a dev build for Android and
> > > forgets the plugin, it will appear to build successfully but not
> > > actually function properly due to the whitelist.
> > >
> > > I know, this is all pre-release, so pain is somewhat expected right
> > > now. I'm worried about the case where cordova-android@4.0.0 is
> > > released and cordova-ios@3.8.0 is still current, and how people can
> > > avoid whitelist breakage there.
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > > For additional commands, e-mail: dev-help@cordova.apache.org
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > For additional commands, e-mail: dev-help@cordova.apache.org
> >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message