cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Raymond Camden <raymondcam...@gmail.com>
Subject Re: Camera: When was Crop added and why?
Date Tue, 31 Mar 2015 21:22:56 GMT
Oh sorry - your last paragraph makes it clear that it is a doc issue
w/ Android then. (Possibly anyway.)

On Tue, Mar 31, 2015 at 4:22 PM, Raymond Camden <raymondcamden@gmail.com> wrote:
> I'm confused. The docs say allowEdit is ignored for Android (and every
> other platform but iOS I believe). Are you saying allowEdit does
> something for Android?
>
> On Tue, Mar 31, 2015 at 4:15 PM, Jesse <purplecabbage@gmail.com> wrote:
>> To be correct, it is not disabled anywhere, it was previously implemented
>> for iOS only.
>> The iOS native camera/capture view has an additional boolean property to
>> allow the user to crop+pan a photo in place before returning to the app.
>> This was exposed in the cordova camera api on iOS only. In like 2011.
>>
>> More recently ( last year [1] ) the same feature landed in Android,
>> however, it is not exactly the same thing.
>> On Android, there is no guarantee that the Crop-Intent exists, in which
>> case it doesn't matter if the cordova-camera getPicture method was called
>> with allowEdit or not.  Also, on some devices, there are multiple apps
>> providing a Crop-Intent, so the user will have to choose one.
>>
>> There are tests for it, but of course, they are manual ...
>> Should we update the docs and claim Android support for it, or does it have
>> usability/implementation issues that make us not want it?
>>
>>
>> [1] https://github.com/apache/cordova-plugin-camera/pull/12
>>
>>
>>
>>
>>
>> @purplecabbage
>> risingj.com
>>
>> On Tue, Mar 31, 2015 at 1:56 PM, Raymond Camden <raymondcamden@gmail.com>
>> wrote:
>>
>>> From what I could see, every platform - but iOS - has it disabled.
>>> (imo, when a feature is ONE platform only, it should really be called
>>> out earlier in the docs.) Going to make a demo now cuz I want to see
>>> too.
>>>
>>> On Tue, Mar 31, 2015 at 3:06 PM, Joe Bowser <bowserj@gmail.com> wrote:
>>> > What does allowEdit do? Does it crop across devices? The problem is that
>>> > this is super vague and doesn't make any sense. Edit can mean anything
>>> from
>>> > a file permission to "Open Photoshop Mobile".  If there's a thread where
>>> we
>>> > decided on it, that'd be cool, but right now it smells like an
>>> undocumented
>>> > feature.
>>> >
>>> > On Tue, Mar 31, 2015, 11:18 AM Shazron <shazron@gmail.com> wrote:
>>> >
>>> >> Isn't this just allowEdit?
>>> >> https://github.com/apache/cordova-plugin-camera/pulls?
>>> >> utf8=✓&q=is%3Apr+is%3Aclosed+crop+
>>> >> <
>>> https://github.com/apache/cordova-plugin-camera/pulls?utf8=%E2%9C%93&q=is%3Apr+is%3Aclosed+crop+
>>> >
>>> >>
>>> >> On Tue, Mar 31, 2015 at 10:38 AM, Joe Bowser <bowserj@gmail.com>
wrote:
>>> >> > Hey
>>> >> >
>>> >> > I'm working on Camera plugin issues in JIRA, and I noticed that
we
>>> added
>>> >> > Crop to the Camera plugin.  I'm wondering when this was done, and
>>> where
>>> >> the
>>> >> > JIRA issue or discussion of adding this feature took place.  I'm
>>> pretty
>>> >> > sure this feature wasn't added properly to Android, since it seems
to
>>> >> > interrupt how the camera works pretty substantially.
>>> >> >
>>> >> > Can anyone direct me to where any of this took place so that I
can
>>> read
>>> >> the
>>> >> > justification as to why we added it?  If it doesn't exist, I'm
>>> probably
>>> >> > going to create a JIRA issue for putting it in properly, since
I'm
>>> sure
>>> >> > some users are expecting it.
>>> >> >
>>> >> > Joe
>>> >>
>>> >> ---------------------------------------------------------------------
>>> >> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
>>> >> For additional commands, e-mail: dev-help@cordova.apache.org
>>> >>
>>> >>
>>>
>>>
>>>
>>> --
>>> ===========================================================================
>>> Raymond Camden, Developer Advocate for MobileFirst at IBM
>>>
>>> Email : raymondcamden@gmail.com
>>> Blog : www.raymondcamden.com
>>> Twitter: raymondcamden
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
>>> For additional commands, e-mail: dev-help@cordova.apache.org
>>>
>>>
>
>
>
> --
> ===========================================================================
> Raymond Camden, Developer Advocate for MobileFirst at IBM
>
> Email : raymondcamden@gmail.com
> Blog : www.raymondcamden.com
> Twitter: raymondcamden



-- 
===========================================================================
Raymond Camden, Developer Advocate for MobileFirst at IBM

Email : raymondcamden@gmail.com
Blog : www.raymondcamden.com
Twitter: raymondcamden

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message