cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michal Mocny <mmo...@chromium.org>
Subject Re: 'cordova plugin save' should also save plugin versions
Date Wed, 25 Mar 2015 04:00:11 GMT
..Also with the move to put plugins in npm, I think we would be directly
using npm's resolution of the version?

On Tue, Mar 24, 2015 at 8:48 PM, Andrew Grieve <agrieve@chromium.org> wrote:

> On Tue, Mar 24, 2015 at 7:48 PM, Gorkem Ercan <gorkem.ercan@gmail.com>
> wrote:
>
> >
> >
> > On 24 Mar 2015, at 18:38, Tim Barham wrote:
> >
> >  +1 from me too (always save version, and allow automatic minor version
> >> upgrades).
> >>
> >>  I like Andrew's idea, my only concern is implementing only a portion of
> > the semver syntax. I personally would assume full semver support after
> > seeing "^1.2.3" notation on config.xml
>
> I think we do already support all semver? Just tried:
>    cordova plugin add "cordova-plugin-okhttp@>1 <3"
>  and it worked fine.
>
>
> >
> >
> >  Gorkem - I'm currently doing some work in this area - I'm happy to make
> >> this change while I'm there.
> >>
> >>  Sure, go ahead. I would not be able to get to it until next week.
> >
> >
> >  ________________________________________
> >> From: Steven Gill [stevengill97@gmail.com]
> >> Sent: Wednesday, March 25, 2015 7:20 AM
> >> To: dev@cordova.apache.org
> >> Subject: Re: 'cordova plugin save' should also save plugin versions
> >>
> >> Definitely agree with alignment with npm's save! :D
> >>
> >> On Tue, Mar 24, 2015 at 1:46 PM, Nikhil Khandelwal <
> >> nikhilkh@microsoft.com>
> >> wrote:
> >>
> >>  I'm in favor of alignment of 'plugin save' behavior with npm's as we
> >>> expect developers to already familiar with that and in future, we plan
> to
> >>> move to npm.
> >>>
> >>> I liked Andrew's idea of adding a specific version with allowing minor
> >>> version upgrades to be automatic.
> >>>
> >>> As for shrink wrapping, for npm this means locking down the version
> >>> numbers of all modules and their dependencies:
> >>> https://docs.npmjs.com/cli/shrinkwrap . It does not look our
> >>> --shrinkwrap
> >>> option does that.
> >>>
> >>> -Nikhil
> >>>
> >>> -----Original Message-----
> >>> From: So, Byoungro [mailto:byoungro.so@intel.com]
> >>> Sent: Tuesday, March 24, 2015 12:40 PM
> >>> To: dev@cordova.apache.org
> >>> Subject: Re: 'cordova plugin save' should also save plugin versions
> >>>
> >>> +1 for making the shrinkwrap as the default for the <save.
> >>> This makes sure the users will restore the same version they saved
> >>> before.
> >>>
> >>> Byoungro So
> >>> SSG / DPD / Mobile Computing and Compilers Intel Corporation
> >>>
> >>>
> >>>
> >>>
> >>>
> >>>
> >>> On 3/24/15, 12:31 PM, "Gorkem Ercan" <gorkem.ercan@gmail.com> wrote:
> >>>
> >>>
> >>>> I think the problem here is shrinkwrap behaviour is the expected
> >>>> because platforms behave that way. I guess we could just make
> >>>> shrinkwrap default and change the flag to --noshrinkwrap.
> >>>> --
> >>>> Gorkem
> >>>>
> >>>> On 24 Mar 2015, at 13:58, Andrew Grieve wrote:
> >>>>
> >>>>  On Tue, Mar 24, 2015 at 11:49 AM, Gorkem Ercan
> >>>>> <gorkem.ercan@gmail.com>
> >>>>> wrote:
> >>>>>
> >>>>>  They are related but not same.
> >>>>>>
> >>>>>> CB-8594 asks to save the plugin version information during "cordova
> >>>>>> plugin add --save". Right now we do not save version unless
the
> >>>>>> command is "cordova plugin add --save --shrinkwrap". This behaviour
> >>>>>> allows plugins to be restored to the latest possible version
> >>>>>> available if they are not explicitly shrinkwrapped.
> >>>>>>
> >>>>>>
> >>>>> How about doing what npm does, and always save the version, but
save
> >>>>> it as "^1.0.3", so that you still get updates, but not major version
> >>>>> changes?
> >>>>>
> >>>>>
> >>>>>
> >>>>>
> >>>>>> As for CB-8733, "cordova plugin save" command can not save the
> >>>>>> version information even if it had wanted to because fetch.json
is
> >>>>>> missing that information. It is a bug.
> >>>>>> --
> >>>>>> Gorkem
> >>>>>>
> >>>>>> On Tue, Mar 24, 2015 at 11:29 AM, Raymond Camden
> >>>>>> <raymondcamden@gmail.com>
> >>>>>> wrote:
> >>>>>>
> >>>>>>  Is that a dupe of https://issues.apache.org/jira/browse/CB-8594?
> >>>>>>>
> >>>>>>> On Tue, Mar 24, 2015 at 10:19 AM, Edna Y Morales
> >>>>>>> <eymorale@us.ibm.com>
> >>>>>>> wrote:
> >>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>>> Currently, version info is not saved for plugins in
the
> fetch.json.
> >>>>>>>>
> >>>>>>> That
> >>>>>>
> >>>>>>> needs to be added so that plugin version can be saved in
the
> >>>>>>>>
> >>>>>>> config.xml.
> >>>>>>
> >>>>>>> It
> >>>>>>>
> >>>>>>>> should follow what 'cordova platform save' does. I created
a jira
> >>>>>>>> item
> >>>>>>>>
> >>>>>>> for
> >>>>>>>
> >>>>>>>> this: https://issues.apache.org/jira/browse/CB-8733
and opened a
> >>>>>>>> pull
> >>>>>>>> request: https://github.com/apache/cordova-lib/pull/189.
If
> >>>>>>>> someone
> >>>>>>>>
> >>>>>>> could
> >>>>>>>
> >>>>>>>> review it and provide any feedback.
> >>>>>>>>
> >>>>>>>> Thanks,
> >>>>>>>> Edna Morales
> >>>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>> --
> >>>>>>>
> >>>>>>>
> >>>>>>
> =====================================================================
> >>>>>> ===
> >>>>>> ===
> >>>>>>
> >>>>>>> Raymond Camden, Developer Advocate for MobileFirst at IBM
> >>>>>>>
> >>>>>>> Email : raymondcamden@gmail.com
> >>>>>>> Blog : www.raymondcamden.com
> >>>>>>> Twitter: raymondcamden
> >>>>>>>
> >>>>>>> -------------------------------------------------------------------
> >>>>>>> -- To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> >>>>>>> For additional commands, e-mail: dev-help@cordova.apache.org
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>
> >>>> ---------------------------------------------------------------------
> >>>> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> >>>> For additional commands, e-mail: dev-help@cordova.apache.org
> >>>>
> >>>>
> >>>
> >>> ---------------------------------------------------------------------
> >>> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> >>> For additional commands, e-mail: dev-help@cordova.apache.org
> >>>
> >>>
> >>> ---------------------------------------------------------------------
> >>> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> >>> For additional commands, e-mail: dev-help@cordova.apache.org
> >>>
> >>>
> >>>  ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> >> For additional commands, e-mail: dev-help@cordova.apache.org
> >>
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > For additional commands, e-mail: dev-help@cordova.apache.org
> >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message