cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Grieve <agri...@chromium.org>
Subject Re: [DISCUSS] Cordova-Android 4.0.0 Release
Date Thu, 19 Mar 2015 17:28:50 GMT
Here's issues:
https://issues.apache.org/jira/browse/CB-8715 (docs)
https://issues.apache.org/jira/browse/CB-8716 (whitelist)
https://issues.apache.org/jira/browse/CB-8717 (write RELEASENOTES.md)

On Tue, Mar 17, 2015 at 10:15 AM, Carlos Santana <csantana23@gmail.com>
wrote:

> I would say let's start RC testing and voting, But not pin the version in
> Cordova CLI until the tasks that Andrew mentioned are done.
> Andrew can you create the JIRA Items for the tasks that need to be done. I
> thought there was a discussion about creating JIRA Items to help track and
> know what's left for release something.
>
> - upgrade guide,
> - publishing whitelist plugins,
> - and making it so that the default project template includes <plugin
> name="cordova-plugin-whitelist" />)
>
>
> On Mon, Mar 16, 2015 at 11:21 PM, Ian Clelland <iclelland@chromium.org>
> wrote:
>
> > We'll probably need at least an RC for the whitelist plugin, if not a
> vote,
> > to be able to vote on this.
> >
> > Or can we just include instructions like "Use
> > cordova-plugin-whitelist@f70b1bc for testing" while we start the
> official
> > release process for the plugins?
> >
> > On Mon, Mar 16, 2015 at 11:17 PM, Ian Clelland <iclelland@chromium.org>
> > wrote:
> >
> > > +1 -- Let's get this out the door :)
> > > I'll see what I can get done to move it in that direction.
> > >
> > > On Mon, Mar 16, 2015 at 7:51 PM, Andrew Grieve <agrieve@chromium.org>
> > > wrote:
> > >
> > >> Everything's ready afaik (minus upgrade guide, publishing whitelist
> > >> plugins, and making it so that the default project template includes
> > >> <plugin name="cordova-plugin-whitelist" />). Maybe let's do a RC
while
> > we
> > >> wait on these things being finished up?
> > >>
> > >> If anyone wants to take on any of these tasks, that would be awesome.
> > >>
> > >> On Mon, Mar 16, 2015 at 4:57 PM, Shazron <shazron@gmail.com> wrote:
> > >>
> > >> > +1 for vote thread, let's get this thing out so people (that are not
> > >> > us) can test...
> > >> >
> > >> >
> > >> > On Mon, Mar 16, 2015 at 1:41 PM, Joe Bowser <bowserj@gmail.com>
> > wrote:
> > >> > > OK, this is a three month old thread, and we're waiting on a
> > >> discussion
> > >> > > before we release something? I really think we should go to a
vote
> > >> thread
> > >> > > now that we have a legacy whitelist plugin and a new style
> whitelist
> > >> > > plugin.  We shouldn't keep constantly delaying this release
> because
> > of
> > >> > > what's happening on other platforms, especially since we already
> > >> > pluginized
> > >> > > the whitelist.
> > >> > >
> > >> > > Can we please release soon?
> > >> > >
> > >> > > On Thu, Mar 12, 2015 at 2:20 PM Nikhil Khandelwal <
> > >> > nikhilkh@microsoft.com>
> > >> > > wrote:
> > >> > >
> > >> > >> I know we discussed a couple of approaches implementing the
> default
> > >> > >> whitelist policy for Android/iOS - either every app would
be
> > >> required to
> > >> > >> include the whitelist plugin or have it have smart defaults
in
> the
> > >> > platform
> > >> > >> implementation and the plugin being able to override them.
> > >> > >>
> > >> > >> I don’t think that thread closed with any conclusions.
> > >> > >>
> > >> > >> Thanks,
> > >> > >> Nikhil
> > >> > >>
> > >> > >>
> > >> > >> -----Original Message-----
> > >> > >> From: Joe Bowser [mailto:bowserj@gmail.com]
> > >> > >> Sent: Thursday, March 12, 2015 11:23 AM
> > >> > >> To: dev
> > >> > >> Subject: Re: [DISCUSS] Cordova-Android 4.0.0 Release
> > >> > >>
> > >> > >> OK, so right now it's just docs? How soon can we get a VOTE
> thread
> > >> > started
> > >> > >> for 4.0.0?
> > >> > >>
> > >> > >> On Wed, Mar 4, 2015 at 10:47 AM Andrew Grieve <
> > agrieve@chromium.org>
> > >> > >> wrote:
> > >> > >>
> > >> > >> > mobilespec is now working again... Took longer than
I would
> have
> > >> > >> > liked, but did you know that on Android FileReader triggers
> > >> > >> > shouldInterceptRequest() with Blob URLs!?
> > >> > >> >
> > >> > >> > Separate thread is already happening re: whitelists,
so once
> > that's
> > >> > >> > figured out, it's just docs afaict.
> > >> > >> >
> > >> > >> > On Mon, Mar 2, 2015 at 10:52 PM, Ian Clelland <
> > >> iclelland@chromium.org
> > >> > >
> > >> > >> > wrote:
> > >> > >> >
> > >> > >> > > On Mon, Mar 2, 2015 at 6:00 PM, Jesse <
> purplecabbage@gmail.com
> > >
> > >> > wrote:
> > >> > >> > >
> > >> > >> > > > We should start a new whitelist plugin related
thread.
> > >> > >> > > >
> > >> > >> > > > Why is a plugin blocking a release?  Default
(aka
> no-plugin)
> > >> > >> > > > behavior should be to allow all network requests
shouldn't
> > it?
> > >> > >> > >
> > >> > >> > >
> > >> > >> > > Well, that just might be a blacklist then :)
> > >> > >> > >
> > >> > >> > >
> > >> > >> > > >   This thread is a
> > >> > >> > > > month long, and not the first discussion of
4.0.0 for
> > Android.
> > >> > >> > > >
> > >> > >> > >
> > >> > >> > > Seriously, though -- the whitelist discussion is
much longer
> > than
> > >> > >> > > that,
> > >> > >> > and
> > >> > >> > > this isn't the first time that the default no-network-access
> > >> policy
> > >> > >> > > has been brought up:
> > >> > >> > >
> > >> > >> > > (Here's the first question, from *July*:
> > >> > >> > > http://markmail.org/message/t4vj4saisem2mcgw
> > >> > >> > > Here's where I mentioned what the implemented policy
was:
> > >> > >> > > http://markmail.org/message/s4necfnh4hnblpjm
> > >> > >> > > And in another discussion:
> > >> > >> > > http://markmail.org/message/ap7syhqysizmsvrz)
> > >> > >> > >
> > >> > >> > > If we want to reconsider that decision, then we
should
> > certainly
> > >> do
> > >> > >> > > so before we cut a release. I think it would be
a real
> problem
> > to
> > >> > >> > > change it afterwards, so let's get it right.
> > >> > >> > >
> > >> > >> > > Also, it's not the plugin itself that's blocking
the release,
> > >> it's
> > >> > >> > > us making sure that we've implemented the core
hooks
> correctly
> > so
> > >> > >> > > that the plugin can actually do its job, and that
people who
> > >> don't
> > >> > >> > > want that particular plugin can make a better one.
> > >> > >> > >
> > >> > >> > > (It is also an issue that a plugin, required for
> > cordova-android
> > >> > >> > > 4.0.0, breaks apps which are also building for
cordova-ios
> > 3.8.0.
> > >> > >> > > I'll take a
> > >> > >> > look
> > >> > >> > > at that, and either remove the ios-native portions
of the
> > >> whitelist
> > >> > >> > plugin,
> > >> > >> > > or neuter it so that it doesn't interfere with
an ios app if
> > it's
> > >> > >> > > not on the unplug-whitelist branch of that repo.)
> > >> > >> > >
> > >> > >> > > Ian
> > >> > >> > >
> > >> > >> > >
> > >> > >> > > > @purplecabbage
> > >> > >> > > > risingj.com
> > >> > >> > > >
> > >> > >> > > > On Mon, Mar 2, 2015 at 2:02 PM, Shazron <shazron@gmail.com
> >
> > >> > wrote:
> > >> > >> > > >
> > >> > >> > > > > legacy-whitelist-plugin should be fixed
so that it
> compiles
> > >> on
> > >> > >> > > > > cordova-ios@3.8.0. It shouldn't be a
problem to fix this
> > at
> > >> > >> > > > > compile
> > >> > >> > or
> > >> > >> > > > > run-time (whichever is applicable here
related to the
> > compile
> > >> > >> > > > > error)
> > >> > >> > > > >
> > >> > >> > > > > On Mon, Mar 2, 2015 at 1:47 PM, Darryl
Pogue
> > >> > >> > > > > <dvpdiner2@gmail.com>
> > >> > >> > > > wrote:
> > >> > >> > > > > > On 2 March 2015 at 13:37, Joe Bowser
<
> bowserj@gmail.com>
> > >> > wrote:
> > >> > >> > > > > >> So, right now the whitelist
changes are what's holding
> > up
> > >> the
> > >> > >> > 4.0.0
> > >> > >> > > > > release
> > >> > >> > > > > >> now?  Is this really the only
thing that's holding up
> > this
> > >> > >> > release?
> > >> > >> > > > > >>
> > >> > >> > > > > >> On Wed Feb 25 2015 at 1:18:26
PM Andrew Grieve <
> > >> > >> > > agrieve@chromium.org>
> > >> > >> > > > > wrote:
> > >> > >> > > > > >>
> > >> > >> > > > > >>> I think we'll also need
to finish with the whitelist
> > >> changes
> > >> > >> > > > > >>> &
> > >> > >> > have
> > >> > >> > > > > both
> > >> > >> > > > > >>> the legacy and new-way whitelist
plugins released
> > before
> > >> we
> > >> > >> > > > > >>> can
> > >> > >> > do
> > >> > >> > > a
> > >> > >> > > > > 4.0.0
> > >> > >> > > > > >>> release (otherwise you wouldn't
be able to write an
> app
> > >> that
> > >> > >> > > > > >>> hits
> > >> > >> > > the
> > >> > >> > > > > >>> network)
> > >> > >> > > > > >>>
> > >> > >> > > > > >
> > >> > >> > > > > > Just FYI, the whitelist stuff is
proving to be a bit
> of a
> > >> pain
> > >> > >> > point.
> > >> > >> > > > > > I'm using cordova-android@master,
and need to install
> > the
> > >> > >> > > > > > legacy-whitelist plugin in order
to make network
> > requests.
> > >> > >> > > > > > Once the plugin is installed, everything
seems to work.
> > >> > >> > > > > >
> > >> > >> > > > > > The problem is that the legacy-whitelist
plugin
> generates
> > >> > >> > > > > > compile errors with cordova-ios@3.8.0,
so now I can't
> > just
> > >> > run
> > >> > >> > > > > > `cordova build`, I need to split
the platforms up and
> > >> > >> > > > > > install/uninstall the plugin in
between. If someone
> > makes a
> > >> > >> > > > > > dev build for Android and forgets
the plugin, it will
> > >> appear
> > >> > >> > > > > > to build successfully but not actually
function
> properly
> > >> due
> > >> > to
> > >> > >> the whitelist.
> > >> > >> > > > > >
> > >> > >> > > > > > I know, this is all pre-release,
so pain is somewhat
> > >> expected
> > >> > >> > > > > > right now. I'm worried about the
case where
> > >> > >> > > > > > cordova-android@4.0.0 is released
and
> cordova-ios@3.8.0
> > is
> > >> > >> > > > > > still current, and how people
> > >> > >> > can
> > >> > >> > > > > > avoid whitelist breakage there.
> > >> > >> > > > > >
> > >> > >> > > > > >
> > >> ------------------------------------------------------------
> > >> > >> > ---------
> > >> > >> > > > > > To unsubscribe, e-mail:
> > dev-unsubscribe@cordova.apache.org
> > >> > >> > > > > > For additional commands, e-mail:
> > >> dev-help@cordova.apache.org
> > >> > >> > > > > >
> > >> > >> > > > >
> > >> > >> > > > >
> > ------------------------------------------------------------
> > >> > >> > ---------
> > >> > >> > > > > To unsubscribe, e-mail:
> dev-unsubscribe@cordova.apache.org
> > >> > >> > > > > For additional commands, e-mail:
> > dev-help@cordova.apache.org
> > >> > >> > > > >
> > >> > >> > > > >
> > >> > >> > > >
> > >> > >> > >
> > >> > >> >
> > >> > >>
> > >> >
> > >> >
> ---------------------------------------------------------------------
> > >> > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > >> > For additional commands, e-mail: dev-help@cordova.apache.org
> > >> >
> > >> >
> > >>
> > >
> > >
> >
>
>
>
> --
> Carlos Santana
> <csantana23@gmail.com>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message