cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mefire O. <ommen...@microsoft.com>
Subject RE: Deprecating the feature tag
Date Wed, 11 Mar 2015 02:03:36 GMT
Thanks, Gorkem.
I reviewed the changes.
Overall, things look good to me, however I left some comments. 

Thanks,
Mefire

-----Original Message-----
From: Gorkem Ercan [mailto:gorkem.ercan@gmail.com] 
Sent: Monday, March 9, 2015 4:49 PM
To: dev
Subject: Re: Deprecating the feature tag


Here is an example

  <plugin name="com.phonegap.plugins.facebookconnect">
         <variable name="APP_ID" value="someID" />
         <variable name="APP_NAME" value="valueee" />
   </plugin>


On 9 Mar 2015, at 19:22, Mefire O. wrote:

> How do you specify variables with the new syntax ?
>
> Thanks,
> Mefire
>
> -----Original Message-----
> From: mmocny@google.com [mailto:mmocny@google.com] On Behalf Of Michal 
> Mocny
> Sent: Monday, March 9, 2015 2:50 PM
> To: dev
> Subject: Re: Deprecating the feature tag
>
> Haven't looked at a patch, but +1 to <plugin> over <feature>
>
> On Mon, Mar 9, 2015 at 4:41 PM, Gorkem Ercan <gorkem.ercan@gmail.com>
> wrote:
>
>>
>> I am about to deprecate the old <feature> tag use for saving plugin 
>> information in favour of <plugin> tag. I have a PR[1] that I hope to 
>> soon merge. The changes are backward compatible,  old feature syntax 
>> will still be respected for read and remove operations but all new 
>> entries will be done with the new syntax. Please review the changes 
>> and let me know if you have any concerns, use cases that I am not 
>> aware of.
>>
>> As a note, this change does not effect the <feature> tags that are 
>> created on platform specific config.xml files. Platforms will still 
>> be using the legacy <feature> tag.
>>
>> [1] https://github.com/apache/cordova-lib/pull/182
>>
>> --
>> Gorkem
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
>> For additional commands, e-mail: dev-help@cordova.apache.org
>>
>>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message