cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dmitry Blotsky <dblot...@microsoft.com>
Subject RE: firefoxos to cordova-medic
Date Mon, 23 Mar 2015 18:30:08 GMT
Hi Willy,

Thank you for contributing support for firefoxos to medic! It appears that you have an older
version of medic: there have been some changes to medic that are incompatible with the old
version. Specifically, in the new medic code you will only need to change the following files
around the highlighted lines:

https://github.com/apache/cordova-medic/blob/master/buildbot-conf/cordova.conf#L297
https://github.com/apache/cordova-medic/blob/master/buildbot-conf/cordova-repos.json#L169

Then, you will need to add the following two files you've created:

https://github.com/marti1125/cordova-medic/blob/master/build_firefoxos.js
https://github.com/marti1125/cordova-medic/blob/master/src/build/makers/firefoxos.js

To make your changes available to us for review and eventual acceptance into the master branch,
you will need make a fork of the medic repo and create a Pull Request (PR). Instructions on
how to do this in general are here: https://help.github.com/articles/using-pull-requests/,
and instructions specific to contributing to Apache Cordova are here: http://wiki.apache.org/cordova/IssueWorkflow#Git_Workflow.

Looking forward to your PR!

Kindly,
Dmitry

-----Original Message-----
From: Willy Aguirre [mailto:marti1125@gmail.com] 
Sent: Monday, March 23, 2015 10:23 AM
To: dev@cordova.apache.org
Subject: firefoxos to cordova-medic

Hi!

I am working in add support for firefoxos to cordova-medic. I really appreciate if you can
give me some instructions or tips to finish my homework ^_^

I make this file
https://github.com/marti1125/cordova-medic/blob/master/build_firefoxos.js
quite similar to other's but I have some restrictions because firefoxos doesn't support all
plugins.

in the new version it has
https://github.com/apache/cordova-medic/blob/master/buildbot-conf/cordova-config.json.sample

but I have this
https://github.com/marti1125/cordova-medic-firefoxos/blob/master/cordova-config.json#L18

I added these lines
https://github.com/marti1125/cordova-medic/blob/master/cordova-repos.json#L91

in cordova.conf
https://github.com/marti1125/cordova-medic/blob/master/cordova.conf#L332

and finally
https://github.com/marti1125/cordova-medic/blob/master/src/build/makers/firefoxos.js
but it doesn't work very well because I got this error  #L16 <https://github.com/marti1125/cordova-medic/blob/master/src/build/makers/firefoxos.js#L16>

Thanks,

Willy

--
Willy Aguirre | @willrre
Blog: http://osgux.tumblr.com/
Mozilla Rep: https://reps.mozilla.org/u/Willy/ Mozilla Hispano - Willyaguirre <https://www.mozilla-hispano.org/documentacion/Usuario:Willyaguirre>
Mime
View raw message