cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From thehuijb <...@git.apache.org>
Subject [GitHub] cordova-android pull request: solves CB-8768 issue where onActivit...
Date Tue, 31 Mar 2015 17:19:37 GMT
Github user thehuijb commented on a diff in the pull request:

    https://github.com/apache/cordova-android/pull/171#discussion_r27500998
  
    --- Diff: framework/src/org/apache/cordova/CordovaWebViewImpl.java ---
    @@ -500,6 +500,7 @@ public void onPageFinishedLoading(String url) {
     
                 clearLoadTimeoutTimer();
     
    +            cordova.onCordovaInit(pluginManager);
    --- End diff --
    
    Applied your suggestions,
    please review once more.
    
    thanks in advance
    
    > On 31 Mar 2015, at 16:13, agrieve <notifications@github.com> wrote:
    > 
    > In framework/src/org/apache/cordova/CordovaWebViewImpl.java <https://github.com/apache/cordova-android/pull/171#discussion_r27482230>:
    > 
    > > @@ -500,6 +500,7 @@ public void onPageFinishedLoading(String url) {
    > >
    > >              clearLoadTimeoutTimer();
    > >
    > > +            cordova.onCordovaInit(pluginManager);
    > I'm not sure it makes sense to wait until onPageFinished to dispatch onCordovaInit.
Why not dispatch at the end of the .init() function?
    > 
    > If the concern is that you want to be able to communicate with the JS, I don't think
onPageFinished guarantees that. Instead, you should have your plugin wait for an exec() to
come in from the JS in order to communicate with it on start-up.
    > 
    > —
    > Reply to this email directly or view it on GitHub <https://github.com/apache/cordova-android/pull/171/files#r27482230>.
    > 
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message