cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From agrieve <...@git.apache.org>
Subject [GitHub] cordova-android pull request: CB-8484: Adds support creating signe...
Date Tue, 31 Mar 2015 01:03:14 GMT
Github user agrieve commented on a diff in the pull request:

    https://github.com/apache/cordova-android/pull/164#discussion_r27446058
  
    --- Diff: bin/templates/cordova/lib/build.js ---
    @@ -409,7 +457,31 @@ function parseOpts(options, resolvedTarget) {
                 console.warn('Build option \'' + options[i] + '\' not recognized (ignoring).');
             }
         }
    +    if (packageArgs.keystore && packageArgs.alias) {
    +        var keystore = path.relative(ROOT, path.resolve(packageArgs.keystore));
    +        ret.packageInfo = new PackageInfo(keystore, packageArgs.alias, packageArgs.keystorePassword,
    +            packageArgs.password, packageArgs.keystoreType);
    +    } else if (fs.existsSync(buildConfig)) {
    --- End diff --
    
    Should just check: `if (buildConfig)`, and show an error if it's set and the file doesn't
exist.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message