cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From agrieve <...@git.apache.org>
Subject [GitHub] cordova-android pull request: CB-8484: Adds support creating signe...
Date Tue, 31 Mar 2015 01:02:42 GMT
Github user agrieve commented on a diff in the pull request:

    https://github.com/apache/cordova-android/pull/164#discussion_r27446020
  
    --- Diff: bin/templates/cordova/lib/build.js ---
    @@ -530,8 +609,54 @@ module.exports.findBestApkForArchitecture = function(buildResults,
arch) {
         throw new Error('Could not find apk architecture: ' + arch + ' build-type: ' + buildResults.buildType);
     };
     
    +function PackageInfo(keystore, alias, keystorePassword, password, storeType) {
    +    keystore = keystore.replace(/\\/g, '\\\\');
    +    this.keystore = {
    +        'name': 'key.store',
    +        'value': keystore
    +    };
    +    this.alias = {
    +        'name': 'key.alias',
    +        'value': alias
    +    };
    +    if (keystorePassword) {
    +        this.keystorePassword = {
    +            'name': 'key.store.password',
    +            'value': keystorePassword
    +        };
    +    }
    +    if (password) {
    +        this.password = {
    +            'name': 'key.alias.password',
    +            'value': password
    +        };
    +    }
    +    if (storeType) {
    +        this.storeType = {
    +            'name': 'key.store.type',
    +            'value': storeType
    +        };
    +    }
    +}
    +
    +PackageInfo.prototype = {
    +    toProperties: function() {
    +        var self = this;
    +        var result = '';
    +        Object.keys(self).forEach(function(key) {
    +            if (self[key]) {
    --- End diff --
    
    Probably should not require the value to be non-empty. Perfectly valid to have `key.alias.password=`
in the file (although not recommended :P)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message