cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From agrieve <>
Subject [GitHub] cordova-plugins pull request: CB-6289 Keyboard plugin on Android
Date Tue, 31 Mar 2015 00:25:50 GMT
Github user agrieve commented on a diff in the pull request:
    --- Diff: keyboard/src/android/ ---
    @@ -0,0 +1,124 @@
    +       Licensed to the Apache Software Foundation (ASF) under one
    +       or more contributor license agreements.  See the NOTICE file
    +       distributed with this work for additional information
    +       regarding copyright ownership.  The ASF licenses this file
    +       to you under the Apache License, Version 2.0 (the
    +       "License"); you may not use this file except in compliance
    +       with the License.  You may obtain a copy of the License at
    +       Unless required by applicable law or agreed to in writing,
    +       software distributed under the License is distributed on an
    +       KIND, either express or implied.  See the License for the
    +       specific language governing permissions and limitations
    +       under the License.
    +package org.apache.cordova.labs.keyboard; 
    +import org.apache.cordova.CallbackContext;
    +import org.apache.cordova.CordovaInterface;
    +import org.apache.cordova.CordovaPlugin;
    +import org.apache.cordova.CordovaWebView;
    +import org.apache.cordova.LOG;
    +import org.json.JSONArray;
    +import org.json.JSONException;
    +import android.content.Context;
    +import android.util.DisplayMetrics;
    +import android.view.View;
    +import android.view.ViewTreeObserver.OnGlobalLayoutListener;
    +import android.view.inputmethod.InputMethodManager;
    +public class Keyboard extends CordovaPlugin {
    +    /**
    +    * Delta height of the visible area, to be treated as keyboard opening.
    +    */
    +    private final static int MinHeghtDelta = 100;
    +    private static final String TAG = "Keyboard";
    +    public void initialize(CordovaInterface cordova, CordovaWebView webView) {
    +        super.initialize(cordova, webView);
    +        Activity activity = cordova.getActivity();
    +        DisplayMetrics metrics = new DisplayMetrics();
    +        activity.getWindowManager().getDefaultDisplay().getMetrics(metrics);
    +        final float density = metrics.density;
    +        final CordovaWebView appView = webView;
    +        final View rootView = activity.getWindow().getDecorView().findViewById(;
    +        OnGlobalLayoutListener list = new OnGlobalLayoutListener() {
    +            int previousHeightDifference = 0;
    +            @Override
    +            public void onGlobalLayout() {
    +                LOG.d(TAG, "Entering global layout notification");
    +            	Rect visibleRect = new Rect();
    +                //r will be populated with the coordinates of your view that area still
    +                rootView.getWindowVisibleDisplayFrame(visibleRect);
    +                int visibleHeight = visibleRect.bottom -;
    +                int viewHeight = rootView.getRootView().getHeight();
    +                int heightDifference = (int)((viewHeight - visibleHeight) / density);
    +                if (heightDifference > MinHeghtDelta 
    +                    && heightDifference != previousHeightDifference) {
    +                    // If the height of the view is bigger then 
    +                    // visible area by delta, then assume that keyboard
    +                    // is shown on the screen.
    +                    appView.sendJavascript("Keyboard.isVisible = true; if (Keyboard.onshow)
    --- End diff --
    The main technical reason to not use sendJavascript is because on Android it's implemented
using `eval()`, and depending on the user's Content-Security-Policy, `eval` may not work.
    `setKeepCallback(false)` is the default, which means you can call the `exec`'s success
or failure callback only once.  `setKeepCallback(true)` allows you to call success/failure
multiple times (so long as each time you also call `setKeepCallback(true)`). To go even further:
    - By waiting for an initial `exec()` to come in, you won't ever send a message to JS before
it's ready to receive one.
    - You don't need to export an extra symbol just to be called by the native code
    - On Android, PluginResults are more efficient than sendJavascript

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message