cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From agrieve <...@git.apache.org>
Subject [GitHub] cordova-plugin-splashscreen pull request: CB-8753 Maintain splash ...
Date Tue, 31 Mar 2015 00:17:25 GMT
Github user agrieve commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-splashscreen/pull/43#discussion_r27444238
  
    --- Diff: src/android/SplashScreen.java ---
    @@ -151,13 +193,40 @@ public Object onMessage(String id, Object data) {
             }
             return null;
         }
    +    
    +    @Override
    +    public void onConfigurationChanged(Configuration newConfig) {
    +        super.onConfigurationChanged(newConfig);
    +
    +        // Reload splash drawable when orientation changes if so configured.
    +        if (newConfig.orientation != orientation) {
    +            orientation = newConfig.orientation;
    +            reloadDrawable();
    +        }
    +    }
     
    -    private void removeSplashScreen() {
    +    private void reloadDrawable() {
    +        if (isReloadOnOrientationChange() && splashImageView != null) {
    --- End diff --
    
    I think a performance hit would be acceptable here given the ease of configuration. How
often are you going to rotate your device while the splash screen is up? Probably close to
never, or at most once.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message