cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nikhilkh <...@git.apache.org>
Subject [GitHub] cordova-android pull request: CB-8484: Adds support creating signe...
Date Mon, 30 Mar 2015 21:07:12 GMT
Github user nikhilkh commented on a diff in the pull request:

    https://github.com/apache/cordova-android/pull/164#discussion_r27431999
  
    --- Diff: bin/templates/cordova/lib/build.js ---
    @@ -422,11 +477,15 @@ function parseOpts(options, resolvedTarget) {
     module.exports.runClean = function(options) {
         var opts = parseOpts(options);
         var builder = builders[opts.buildMethod];
    -    return builder.prepEnv()
    +    return builder.prepEnv(opts)
         .then(function() {
    -        return builder.clean(opts.extraArgs);
    +        return builder.clean(opts);
         }).then(function() {
             shell.rm('-rf', path.join(ROOT, 'out'));
    +    }).then(function() {
    +        ['debug', 'release'].forEach(function(config) {
    +            removeIfExists(path.join(ROOT, config + SIGNING_PROPERTIES));
    --- End diff --
    
    I was really hoping to get the scenario of CLI + IDE (Android studio) interop working.
If they both consume the same .properties file they can interoperate. The user could create
a build.json file with the correct values and would be able to achieve this. I'm getting inclined
to delete the file _only_ when it is autogenerated.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message