cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From TimBarham <>
Subject [GitHub] cordova-lib pull request: CB-8754 Auto-restoring a plugin fails wh...
Date Fri, 27 Mar 2015 14:40:09 GMT
Github user TimBarham commented on a diff in the pull request:
    --- Diff: cordova-lib/src/util/npm-helper.js ---
    @@ -0,0 +1,76 @@
    + Licensed to the Apache Software Foundation (ASF) under one
    + or more contributor license agreements.  See the NOTICE file
    + distributed with this work for additional information
    + regarding copyright ownership.  The ASF licenses this file
    + to you under the Apache License, Version 2.0 (the
    + "License"); you may not use this file except in compliance
    + with the License.  You may obtain a copy of the License at
    + Unless required by applicable law or agreed to in writing,
    + software distributed under the License is distributed on an
    + KIND, either express or implied.  See the License for the
    + specific language governing permissions and limitations
    + under the License.
    + */
    +// Helper methods to help keep npm operations separated.
    +var npm = require('npm'),
    +    Q = require('q'),
    +    cachedSettings = null,
    +    cachedSettingsValues = null;
    + * @description Calls npm.load, then initializes npm.config with the specified settings.
Then executes a chain of
    + * promises that rely on those npm settings, then restores npm settings back to their
previous value. Use this rather
    + * than passing settings to npm.load, since that only works the first time you try to
load npm.
    + * @param {Object} settings
    + * @param {Function} promiseChain
    + */
    +function loadWithSettingsThenRestore(settings, promiseChain) {
    +    return loadWithSettings(settings).then(promiseChain).then(restoreSettings);
    --- End diff --
    Yes, indeed it should ... good point :)

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message