cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From agrieve <...@git.apache.org>
Subject [GitHub] cordova-android pull request: CB-8484: Adds support creating signe...
Date Fri, 27 Mar 2015 01:07:13 GMT
Github user agrieve commented on a diff in the pull request:

    https://github.com/apache/cordova-android/pull/164#discussion_r27270342
  
    --- Diff: bin/templates/cordova/lib/build.js ---
    @@ -422,11 +477,15 @@ function parseOpts(options, resolvedTarget) {
     module.exports.runClean = function(options) {
         var opts = parseOpts(options);
         var builder = builders[opts.buildMethod];
    -    return builder.prepEnv()
    +    return builder.prepEnv(opts)
         .then(function() {
    -        return builder.clean(opts.extraArgs);
    +        return builder.clean(opts);
         }).then(function() {
             shell.rm('-rf', path.join(ROOT, 'out'));
    +    }).then(function() {
    +        ['debug', 'release'].forEach(function(config) {
    +            removeIfExists(path.join(ROOT, config + SIGNING_PROPERTIES));
    --- End diff --
    
    hmm, maybe for this reason you should pass the parameters on the command line as gradle
properties so that there is no file to clean up. Note that it's unlikely the ANT workflow
is important anymore, as gradle is the new default and seems to work much better.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message